Phpactor 0.9 compatibility #43
Merged
+126
−109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@kermorgant refs #47 |
Contributor
Author
|
@zonuexe yes, I was initially planning a phpactor 0.9.0 release but I could merge that this evening if you prefer |
This was referenced Aug 16, 2018
kermorgant
force-pushed
the
phpactor_0.9-compatibility
branch
2 times, most recently
from
713e921 to
d4234e3
Compare
Contributor
Author
|
I just added some changes following recent release of phpactor 0.9. I'll use it a bit before asking for review. |
Contributor
Author
|
still needs support for |
kermorgant
commented
Sep 14, 2018
| (set-buffer buf) | ||
| (revert-buffer t t t)) | ||
| (find-file path))) | ||
| (goto-char (1+ (byte-to-position offset)))) |
Contributor
Author
There was a problem hiding this comment.
btw, I got
Wrong type argument: number-or-marker-p, nil
generated by byte-to-position given offset 0
kermorgant
force-pushed
the
phpactor_0.9-compatibility
branch
from
68d30b3 to
3ccad9b
Compare
following those issues : emacs-php#41 emacs-php#42 emacs-php#56 replace deprecated rpc call and deprecated info key use the newer key short_description and class_import add "version" arg to phpactor-action-dispatch require specific rpc protocol version : This is a quite untolerant position towards future and maybe compatible versions of the rpc protol. probably a good idea to revisit this as soon as possible. add support for force_reload flag target phpactor 0.9 in composer.json
kermorgant
force-pushed
the
phpactor_0.9-compatibility
branch
from
0d4bfaf to
4a5fc2c
Compare
Contributor
Author
|
@zonuexe I think we could merge this now. Is it ok for you ? |
zonuexe
reviewed
Sep 19, 2018
| ;; Copyright (C) 2018 Friends of Emacs-PHP development | ||
|
|
||
| ;; Author: USAMI Kenta <tadsan@zonu.me> | ||
| ;; Mikael Kermorgant <mikael@kgtech.fi> |
|
|
||
| ;; Author: USAMI Kenta <tadsan@zonu.me> | ||
| ;; Mikael Kermorgant <mikael@kgtech.fi> | ||
|
|
| (defvar phpactor--buffer-name "*Phpactor*") | ||
|
|
||
| (defconst phpactor-command-name "phpactor") | ||
| (defconst phpactor--supported-rpc-version "1.0.0") |
zonuexe
approved these changes
Sep 19, 2018
|
|
||
| (let ((buf (find-buffer-visiting path))) | ||
| (when (and force_reload buf) | ||
| (progn |
Member
|
@kermorgant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #41, #42 and #56
references
infofield in suggestions phpactor/phpactor#547replace_file_source=>update_file_sourcephpactor/phpactor#550replace deprecated rpc call and deprecated info key
use the newer key short_description and class_import
add support for "version" arg to phpactor-action-dispatch (require specific rpc protocol version : This is a quite untolerant position towards future and maybe compatible versions of the rpc protol. probably a good idea to revisit this as soon as possible).
add support for force_reload flag
target phpactor 0.9 in composer.json