Skip to content

Conversation

@kermorgant
Copy link
Contributor

add support for phpactor's file_info rpc action which returns class FQN, name and namespace about currently open file (see PR bringing this into phpactor)

@kermorgant
Copy link
Contributor Author

Not sure the phpactor-insert-namespace really belongs here. Opinions ?

@kermorgant kermorgant requested a review from zonuexe September 22, 2018 20:16
@kermorgant kermorgant changed the title add support for file_info rpc action + insert-namespace function add support for file_info rpc action Sep 22, 2018
Copy link
Member

@zonuexe zonuexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejmr
Copy link

ejmr commented Sep 23, 2018

Not sure the phpactor-insert-namespace really belongs here. Opinions?

Since the subject of the code is relevant file info (apparently), the namespace for the given code in a file seems appropriately on target. Unless I am misunderstanding the purpose of that piece of code.

@kermorgant
Copy link
Contributor Author

phpactor-file-information refers to the file_info rpc action, whereas php-insert-namespace is a trivial function using it.

In other words, I wonder if at some point, we should differentiate the functions aimed at bringing phpactor.el to emacs from other built upon them.

@kermorgant kermorgant merged commit 9ca0352 into emacs-php:master Sep 24, 2018
@kermorgant kermorgant deleted the file-info branch September 24, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants