Build against drivine 73 - #72
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild dice-storage against Drivine 0.0.73 (ABI fix), and stop the codegen version drifting
Why this is needed
Drivine 0.0.73 added a
nullPolicyparameter toGraphObjectManager.save/saveAll. That changes the signature of the synthetic Kotlin default-args bridge, so the method a consumer compiled against no longer exists:Old bridge:
save$default(gom, obj, CascadeType, int, Object). New bridge:save$default(gom, obj, CascadeType, NullPolicy, int, Object).This is a binary break, not a source break. Any module compiled against Drivine ≤ 0.0.72 that calls
save(x)orsave(x, cascade)relying on defaults still compiles, and then throws at runtime the first time that line executes.@JvmOverloadsdoes not preserve the old$defaultABI.`
embabel-chat-store has been updated as well.