Updating embark demo to use react instead of jquery #382

richard-ramos · 2018-04-26T17:44:58Z

No description provided.

Blockchain tab complete Whisper tab complete (requires status indicator yet)

jrainville

Small requests. Otherwise, this is pretty dope! 👍

jrainville · 2018-04-26T18:24:21Z

templates/demo/app/components/blockchain.js

+
+      this.setValue = this.setValue.bind(this);
+      this.getValue = this.getValue.bind(this);
+      this.handleChange = this.handleChange.bind(this);


Just an FYI, you don't need to premptively bind your functions if you call them with arrows. Eg:

onClick={(e) => this.setValue(e)}

or

handleChange = (e) => { this.setState({valueSet: e.target.value}); };

Updated the components based on this suggestion. Also, there were some let _this = this; that were removed after changing the functions to arrow functions.

jrainville · 2018-04-26T18:25:57Z

templates/demo/app/components/blockchain.js

+                type="text"
+                defaultValue={this.state.valueSet}
+                onChange={this.handleChange}/>
+              {' '}


What is this for? If it is just to add a spacer, maybe use a css margin?

Fixed: Added a margin-right to input.form-control in dapp.css to avoid having to use spacers

jrainville · 2018-04-26T18:27:47Z

templates/demo/app/components/storage.js

+                })
+            .catch(function(err) {
+                if(err){
+                    console.log("Storage uploadFile Error => " + err.message);


Maybe we should show the error with a state change for it to be clearer to the user.

Fixed: The screen shows an error notice when there's an error when using the storage.

jrainville · 2018-04-26T18:29:58Z

templates/demo/app/components/whisper.js

+                        defaultValue={this.state.listenTo}
+                        placeholder="channel"
+                        onChange={e => this.handleChange(e, 'listenTo')} />
+                    {' '}


Again, use a margin if this is only for space.

jrainville · 2018-04-26T18:32:02Z

templates/demo/app/dapp.js

+  componentDidMount(){ 
+    let _this = this;
+
+    setTimeout(() => {


Why do you need a timeout?

EmbarkJS.Messages.Providers.whisper is not available when the component mounts

@iurimatias , would there be a better way to wait for whisper, like an event?

jrainville

You only forgot one spacer. Also, I'm wondering if Iuri has an answer the timer needed for Whisper.

jrainville · 2018-04-27T15:27:24Z

templates/demo/app/components/blockchain.js

+                type="text"
+                defaultValue={this.state.valueSet}
+                onChange={(e) => this.handleChange(e)} />
+              {' '}


Forgot one here

oops! fixed now!

richard-ramos · 2018-04-27T15:51:55Z

@jrainville Removed the timeout by using __embarkContext.execWhenReady( ... );
It would be good to have that function available with a more user friendly name, equivalent to jquery having

$(function(){
// code here
});

jrainville · 2018-04-27T16:25:19Z

One of test fails

Adding swarm to embarkjs. WIP. Add 'auto' setting for geth CORS and websockets origin * 'auto' now supported for `rpcCorsDomain` and `wsOrigins` in the blockchain config. * 'auto' set to the default value in blockchain config for test and demo apps. test add config and contract and add test addFileToPipeline test and registerBeforeDeploy with new arg add more registers but generation one fails in run WIP commit Undo changes to test config. Merge pull request #381 from embark-framework/features/cors-auto Add 'auto' setting for geth CORS and websockets origin fix a bug where upload cmd used plugin name don't error if it's an empty dapp with no contracts yet Merge pull request #383 from embark-framework/no_contracts don't error if it's an empty dapp with no contracts yet remove duplicated entry force zepplein version for travis Merge pull request #384 from embark-framework/chores/test-allpligin-apis Small fixes for plugin APIs intercept logs in the app itself - stopgap fix Merge pull request #385 from embark-framework/console_logs_fix intercept logs in the app itself - stopgap fix * removed unneeded provider property. * add 'swarm' as a provider in the storage.config * update method for swarm service check Merge branch 'develop' into features/add-swarm-to-embarkjs More work to add swarm to embarkjs * added eth-lib to parse result of swarm text * changed "currentStorage" and "currentMessages" to "currentProvider" for consistency. * added protocol to storage config * selectively starts storage service depending on which one is configured in the storage config * run service check for ipfs/swarm prior to uploaded * added swarm methods for embarkjs Updated code based on code review check if testrpc is installed and warn if not Merge pull request #386 from embark-framework/bug_fix/test-rpc-not-installed check if testrpc is installed and warn if not Removed timeout Removed spacer Merge pull request #382 from embark-framework/react-demo Updating embark demo to use react instead of jquery fix on contract add Merge pull request #387 from embark-framework/bug_fix/new-contract-in-empty-dapp Fix adding a contract redeploy with right config on config change fix tests reset watchers after build to make sure files remain watch Merge pull request #389 from embark-framework/bug_fix/file-changes-not-watched Fix files not being watched Merge pull request #388 from embark-framework/bug_fix/changing-contract-config Redeploy with right config on config change Added swarm support in embarkjs and isAvailable for messages/storage * reverted currentProvider back to currentStorage and currentMessages * added `EmbarkJS.Storage.isAvailable` and `EmbarkJS.Messages.isAvailable()` and underlying provider functions for Whisper, Orbit, IPFS, and Swarm * Finished swarm implementation in embarkjs plus cleanup * updated test app storage config to swarm to show swarm config option Merge branch 'develop' into features/add-swarm-to-embarkjs

emizzle · 2018-04-30T12:33:39Z

templates/demo/app/dapp.js

+    this.state = {
+      whisperEnabled: false,
+      storageEnabled: false
    }


In #390 (not yet approved/merged), this can be achieved with EmbarkJS.Storage.isAvailable() and EmbarkJS.Messages.isAvailable()

richard-ramos added 3 commits April 23, 2018 16:42

Migrating demo to react

28b8eff

Blockchain tab complete Whisper tab complete (requires status indicator yet)

Added storage section

baffdb8

Added whisper status indicator

3b13a2c

richard-ramos requested review from VoR0220, emizzle, iurimatias and jrainville April 26, 2018 17:44

iurimatias added the in progress label Apr 26, 2018

jrainville requested changes Apr 26, 2018

View reviewed changes

Updated code based on code review

c8effb7

jrainville reviewed Apr 27, 2018

View reviewed changes

richard-ramos added 2 commits April 27, 2018 11:47

Removed timeout

dbb6406

Removed spacer

57428a6

jrainville approved these changes Apr 27, 2018

View reviewed changes

iurimatias merged commit bbec433 into develop Apr 27, 2018

emizzle reviewed Apr 30, 2018

View reviewed changes

iurimatias deleted the react-demo branch May 8, 2018 17:39

Updating embark demo to use react instead of jquery #382

Updating embark demo to use react instead of jquery #382

Uh oh!

Conversation

richard-ramos commented Apr 26, 2018

Uh oh!

jrainville left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richard-ramos Apr 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jrainville left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

richard-ramos commented Apr 27, 2018

Uh oh!

jrainville commented Apr 27, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

richard-ramos Apr 27, 2018 •

edited

Loading