npm should not ignore templates' .gitignore files #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsbradleyjr
changed the title
michaelsbradleyjr
requested review from
alaibe,
andremedeiros,
emizzle,
iurimatias,
jrainville and
richard-ramos
jrainville
approved these changes
Aug 10, 2018
This was referenced Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
npm packwas by default ignoring the.gitignorefiles within the template directories. With this change, it doesn't ignore them.Compare the results of:
^ both of those are missing the
.gitignorefilesIt was easy to miss this since during development we're often working with embark installed from a clone of the github repo vs. a tarball packed by
npm.Post approval and merge, I will cherry pick this commit into a branch off
3_1_0, then submit a PR for merging into3_1_0.