Template .gitignore — round 2 #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsbradleyjr
requested review from
alaibe,
andremedeiros,
emizzle,
iurimatias,
jrainville and
richard-ramos
jrainville
approved these changes
Aug 13, 2018
jrainville
reviewed
Aug 13, 2018
| utils.cd(templatePath); | ||
| utils.sed('package.json', '%APP_NAME%', name); | ||
| if (fs.existsSync('dot.gitignore')) { | ||
| fs.moveSync('dot.gitignore', '.gitignore'); |
Collaborator
There was a problem hiding this comment.
Won't move make the file "disappear" form the global install? Making it impossible to install the template twice? Shouldn't you copy instead?
Contributor
Author
There was a problem hiding this comment.
It's only being moved inside the template instance. templatePath is the same as fspath a few lines above, which is derived from destinationFolder.
I was, though, concerned about this very thing. So I manually checked that it's only getting moved inside the template instance, and that in embark's template dir the file is still dot.gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When embark is installed via npm, the templates'
.gitignorefiles (which make it into the pkg tarball by way of the negation included in embark's.npmignore, owing to #694) are auto-renamed to.npmignore. This npm behavior cannot be remedied, it seems, by including empty.npmignorefiles in the template directories.So, this PR uses a different approach: template directories have a file named
dot.gitignoreand during template installation (viaembark demoorembark new) the copieddot.gitignore(within the template instance) is renamed to.gitignore.