fix: sonarqube issues - #67
Merged
Merged
Conversation
Closed
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ ACTION | actionlint | 5 | 0 | 0 | 0.27s | |
| ✅ CPP | clang-format | 108 | 1 | 0 | 0 | 0.47s |
| ✅ CPP | cppcheck | 108 | 0 | 0 | 3.63s | |
| ✅ DOCKERFILE | hadolint | 1 | 0 | 0 | 0.3s | |
| ✅ JSON | jsonlint | 8 | 0 | 0 | 0.15s | |
| ✅ JSON | prettier | 8 | 8 | 0 | 0 | 0.48s |
| markdownlint | 18 | 1 | 32 | 0 | 1.35s | |
| ✅ MARKDOWN | markdown-table-formatter | 18 | 1 | 0 | 0 | 0.23s |
| lychee | 89 | 19 | 0 | 1.85s | ||
| ✅ YAML | prettier | 12 | 6 | 0 | 0 | 0.66s |
| ✅ YAML | yamllint | 12 | 0 | 0 | 0.43s |
Detailed Issues
⚠️ SPELL / lychee - 19 errors
[IGNORED] url.https://github.com/.insteadOf | Unsupported: Error creating request client: builder error for url (url.https://github.com/.insteadOf)
[ERROR] file://doc/analysis/doc/analysis/DctFlow.svg | Cannot find file
[ERROR] file://doc/analysis/doc/analysis/DctBasis.svg | Cannot find file
[ERROR] https://gitlab-ci-token/ | Network error: error sending request for url (https://gitlab-ci-token/) Maybe a certificate error?
[403] https://gitlab.com/embedded-library/infrastructure/hal-st.git | Network error: Forbidden
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/6 | Network error: Not Found
[403] https://gitlab.com/embedded-library/infrastructure/embedded-infra-lib.git | Network error: Forbidden
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/7 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/26 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/2 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/12 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/9 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/27 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/3 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/24 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/15 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/18 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/1 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/4 | Network error: Not Found
[403] https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$ | Network error: Forbidden
📝 Summary
---------------------
🔍 Total...........80
✅ Successful......52
⏳ Timeouts.........0
🔀 Redirected.......0
👻 Excluded.........8
❓ Unknown..........0
🚫 Errors..........19
Errors in doc/analysis/DiscreteCosineTransform.md
[ERROR] file://doc/analysis/doc/analysis/DctFlow.svg | Cannot find file
[ERROR] file://doc/analysis/doc/analysis/DctBasis.svg | Cannot find file
Errors in .gitlab-ci.yml
[403] https://gitlab.com/embedded-library/infrastructure/embedded-infra-lib.git | Network error: Forbidden
[403] https://gitlab.com/embedded-library/infrastructure/hal-st.git | Network error: Forbidden
[ERROR] https://gitlab-ci-token/ | Network error: error sending request for url (https://gitlab-ci-token/) Maybe a certificate error?
Errors in CHANGELOG.md
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/27 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/3 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/2 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/12 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/7 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/6 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/26 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/9 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/15 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/18 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/1 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/4 | Network error: Not Found
[404] https://github.com/embedded-pro/embedded-numerical-toolbox/issues/24 | Network error: Not Found
Errors in .github/workflows/static-analysis.yml
[403] https://binaries.sonarsource.com/Distribution/sonar-scanner-cli/sonar-scanner-cli-$ | Network error: Forbidden
⚠️ MARKDOWN / markdownlint - 32 errors
doc/analysis/DiscreteCosineTransform.md:34 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/DiscreteCosineTransform.md:53 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/FastFourierTransform.md:9 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/FastFourierTransform.md:15 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/FastFourierTransform.md:42 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/FastFourierTransform.md:125 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/PowerDensitySpectrum.md:22 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/analysis/PowerDensitySpectrum.md:37 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/controllers/Pid.md:11 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/controllers/Pid.md:32 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/LinearRegression.md:24 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/LinearRegression.md:39 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/LinearRegression.md:247 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/LinearRegression.md:256 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:26 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:41 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:47 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:242 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:250 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/estimators/YuleWalker.md:260 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/filters/active/KalmanFilter.md:9 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/filters/active/KalmanFilter.md:27 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/filters/active/KalmanFilter.md:35 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/filters/active/KalmanFilter.md:41 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/neural_network/NeuralNetwork.md:32 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/neural_network/NeuralNetwork.md:49 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/solvers/LevinsonDurbin.md:25 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/solvers/LevinsonDurbin.md:43 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/solvers/LevinsonDurbin.md:220 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
doc/solvers/LevinsonDurbin.md:233 MD040/fenced-code-language Fenced code blocks should have a language specified [Context: "```"]
README.md:1 MD041/first-line-heading/first-line-h1 First line in a file should be a top-level heading [Context: "[![Quality Gate Status](https:..."]
README.md:9:401 MD013/line-length Line length [Expected: 400; Actual: 442]
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.1.0 --custom-flavor-setup --custom-flavor-linters ACTION_ACTIONLINT,CPP_CPPCHECK,CPP_CLANG_FORMAT,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_PRETTIER,MARKDOWN_MARKDOWNLINT,MARKDOWN_MARKDOWN_TABLE_FORMATTER,SPELL_LYCHEE,YAML_PRETTIER,YAML_YAMLLINT
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies compiler optimization attributes and adds coverage target support to the build system.
- Updates the
OPTIMIZE_FOR_SPEEDmacro to usealways_inlineinstead offlattenfor GCC builds - Adds explicit
always_inlineattribute to the Clang version of the macro - Integrates code coverage target generation into the CMake build configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| numerical/math/CompilerOptimizations.hpp | Replaces flatten with always_inline for GCC and adds always_inline to Clang's optimization macro |
| CMakeLists.txt | Adds emil_coverage_targets call to enable code coverage reporting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.