try cp-property-map codemod from ember-3x-codemods#727
Merged
kellyselden merged 3 commits intoember-cli:masterfrom Oct 23, 2019
Merged
try cp-property-map codemod from ember-3x-codemods#727kellyselden merged 3 commits intoember-cli:masterfrom
kellyselden merged 3 commits intoember-cli:masterfrom
Conversation
kellyselden
requested changes
Oct 22, 2019
| return `${this.firstName} ${this.lastName}`; | ||
| }, | ||
|
|
||
| friendNames: map('friends', ['nameKey'], function(friend) { |
Member
There was a problem hiding this comment.
Can you import map? Just in case the codemod starts following the source in the future, and not codemodding things that don't come from ember.
Contributor
Author
There was a problem hiding this comment.
Sure, similarly for the computed properties also we need to import the computed right?
Member
There was a problem hiding this comment.
Probably, but I wouldn't worry about it for this pull request
Contributor
Author
There was a problem hiding this comment.
Ok then, I will make changes for importing map
Addressing review comments
kellyselden
approved these changes
Oct 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ember-cli/ember-cli-update-codemods-manifest#21