Skip to content

try cp-property-map codemod from ember-3x-codemods #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kellyselden merged 3 commits into from
Oct 23, 2019
Merged

try cp-property-map codemod from ember-3x-codemods #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71db179
[FEAT] Add computed-property property() Modifier codemod
rajasegar Oct 18, 2019
217284f
[CHORE] Importing map for the computed properties
rajasegar Oct 23, 2019
a10d471
revert
Oct 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions test/fixtures/codemod/latest-node/my-app/app/controllers/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Controller from '@ember/controller';
import Ember from 'ember';
import { assign } from '@ember/polyfills';
import { map } from '@ember/object/computed';

export default Controller.extend({
fullName: computed('firstName', 'lastName', function() {
Expand All @@ -11,6 +12,10 @@ export default Controller.extend({
return `${this.firstName} ${this.lastName}`;
},

friendNames: map('friends', ['nameKey'], function(friend) {
Copy link
Copy Markdown
Member

@kellyselden kellyselden Oct 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you import map? Just in case the codemod starts following the source in the future, and not codemodding things that don't come from ember.

Copy link
Copy Markdown
Contributor Author

@rajasegar rajasegar Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, similarly for the computed properties also we need to import the computed right?

Copy link
Copy Markdown
Member

@kellyselden kellyselden Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but I wouldn't worry about it for this pull request

Copy link
Copy Markdown
Contributor Author

@rajasegar rajasegar Oct 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok then, I will make changes for importing map

return friend[this.nameKey];
}),

actions: {
foo(object) {
this.doStuff(object);
Expand Down
5 changes: 5 additions & 0 deletions test/fixtures/codemod/local/my-app/app/controllers/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import Ember from 'ember';
import { merge } from '@ember/polyfills';
import { map } from '@ember/object/computed';

export default Ember.Controller.extend({
fullName: computed(function() {
Expand All @@ -10,6 +11,10 @@ export default Ember.Controller.extend({
return `${this.firstName} ${this.lastName}`;
}).volatile('firstName', 'lastName'),

friendNames: map('friends', function(friend) {
return friend[this.nameKey];
}).property('nameKey'),

actions: {
foo(object) {
Ember.propertyWillChange(object, 'someProperty');
Expand Down
5 changes: 5 additions & 0 deletions test/fixtures/codemod/min-node/my-app/app/controllers/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import Controller from '@ember/controller';
import Ember from 'ember';
import { assign } from '@ember/polyfills';
import { map } from '@ember/object/computed';

export default Controller.extend({
fullName: computed('firstName', 'lastName', function() {
Expand All @@ -11,6 +12,10 @@ export default Controller.extend({
return `${this.firstName} ${this.lastName}`;
},

friendNames: map('friends', ['nameKey'], function(friend) {
return friend[this.nameKey];
}),

actions: {
foo(object) {
this.doStuff(object);
Expand Down