Fix CI for ember-release/beta/canary (Ember 7) - #1536
Merged
Conversation
Ember 7 publishes ember-source as a v2 addon and no longer ships AMD/vendor bundles (https://deprecations.emberjs.com/id/using-amd-bundles), which broke the release/beta/canary try scenarios: - ember-cli 5.12 crashed reading `emberSource.paths.debug` in _initVendorFiles; ember-cli >= 6.11 handles the missing vendor files - ember-cli-htmlbars 6.x crashed reading the removed `templateCompiler` path; requires >= 7 - ember-resolver 11 does `import Ember from 'ember'`, removed in Ember 7; requires >= 13 - ember-auto-import >= 2.13.1 is required to serve the ember modules, per the deprecation guide (bumped the addon's own dependency floor since a scenario devDependency override can't win over it) - @glimmer/component is now a peerDependency of ember-source The modern tooling is applied via per-scenario devDependency overrides so the LTS scenarios and the base setup keep their current versions. The try-scenarios CI job moves to Node 22 because ember-cli >= 6.10 requires node >= 20.19. All five try scenarios plus the base test suite pass locally (70/70). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
ember-release,ember-beta, andember-canarytry scenarios have been failing since the release channel moved to Ember 7. Ember 7 publishesember-sourceas a v2 addon and no longer ships the AMD/vendor bundles — see the using-amd-bundles deprecation guide and RFC 1101. Our pinned tooling chokes on that, failing one layer at a time:ember-cli@5.12crashes in_initVendorFilesreadingemberSource.paths.debug(Cannot read properties of undefined (reading 'debug'))ember-cli-htmlbars@6.xcrashes reading the removedtemplateCompilerpathember-resolver@11doesimport Ember from 'ember', which no longer existsFix
tests/dummy/config/ember-try.js: the three Ember 7 channel scenarios now override the build tooling to versions that support v2ember-source(ember-cli@^6.11,ember-cli-htmlbars@^7,@ember/test-helpers@^5,ember-resolver@^13,ember-qunit@^9.1,@glimmer/component@^2— now a peer of ember-source). Kept as per-scenario overrides so the LTS scenarios and the base setup stay on their current versions.package.json: bumped the addon'sember-auto-importdependency floor^2.7.0→^2.13.1, the minimum version that provides the ember modules per the deprecation guide. (It has to be the real dependency: a scenario devDependency override can't win over the production dependency resolution.).github/workflows/ci.yml: the try-scenarios job moves from Node 18 to Node 22, sinceember-cli >= 6.10requires Node >= 20.19.Verification
Ran locally:
pnpm test:ember(ember-source 6.10.1)🤖 Generated with Claude Code