convert loose mode to strict mode#305
Merged
NullVoxPopuli merged 4 commits intoember-cli:masterfrom Apr 16, 2026
Merged
Conversation
Merged
NullVoxPopuli
force-pushed
the
nvp/hbs-to-gjs
branch
from
43291ae to
c638f5a
Compare
Member
|
is the title of this wrong? 🤔 I don't see any hbs in the addon changing to gjs, it's all just the docs app. And since it's the docs app is there any value in having it be gts instead of the looser gjs? |
Contributor
Author
|
Yes, type safety is valuable in tests and docs |
Contributor
Author
|
The original code is ts, so gts makes the most sense |
Contributor
Author
|
Title made more generic. Apologies for shorthand |
void-mAlex
reviewed
Apr 14, 2026
void-mAlex
approved these changes
Apr 16, 2026
Open
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
90% of this PR is hbs -> gjs, 10% of this PR is supporting that
these have to happen at the same time because:
extractions: