Merged
Conversation
Contributor
Author
|
The failures are expected, because:
|
Contributor
what tricks? |
Contributor
Author
hoisting ember-source to the root node_modules via public-hoist-pattern -- it turns out the npmrc already specifies this |
Open
This was referenced Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In prep for updating the repo's test / infra for ember 7, I want to remove dep injection and resort to "tricks" to get things resolving correctly.
main reason is that while dep injection is the "most correct", I don't have patience to deal with its ergo blunders anymore