Skip to content

[WIP] Github Gist backend#1

Merged
alexspeller merged 11 commits intoember-cli:masterfrom
joostdevries:master
Mar 28, 2015
Merged

[WIP] Github Gist backend#1
alexspeller merged 11 commits intoember-cli:masterfrom
joostdevries:master

Conversation

@joostdevries
Copy link
Copy Markdown
Member

Do not merge

Some initial work on using the Github API for this

  • Implement Github Oauth using Torii
  • Persist session in cookie
  • Fetch gist
  • Clean up Github code
  • Write serializer/adapter for gist <---> file
  • UI tweaks

New pointers

  • Block files whose content > 1 MB (will require additional API logic + it's insane to fiddle files that large)

Comment thread app/services/github.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ic.ajax instead here

@joostdevries
Copy link
Copy Markdown
Member Author

@alexspeller cleaned up the code.

@alexspeller
Copy link
Copy Markdown
Member

This is looking great, do you want me to merge now or wait for the other checklist items?

@joostdevries
Copy link
Copy Markdown
Member Author

I'd rather have to complete flow working first. I might run into stuff forcing me to refactor.

Comment thread app/lib/gist.js Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use arrows instead of self = this

@joostdevries
Copy link
Copy Markdown
Member Author

@alexspeller maybe we should setup Travis for this?

@joostdevries
Copy link
Copy Markdown
Member Author

@joostdevries
Copy link
Copy Markdown
Member Author

The demo app is not rendering yet (don't know why) and module resolving is not working atm.

@joostdevries
Copy link
Copy Markdown
Member Author

@alexspeller I've created a gists branch. Maybe it's better to merge my work into that so we can both work on it?

@joostdevries
Copy link
Copy Markdown
Member Author

@alexspeller two questions:

alexspeller added a commit that referenced this pull request Mar 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants