Add support for vim, emacs, and sublime key maps#116
Add support for vim, emacs, and sublime key maps#116Gaurav0 merged 1 commit intoember-cli:masterfrom
Conversation
8aad616 to
f74364d
Compare
There was a problem hiding this comment.
Would you mind refactoring this into a component?
|
Love this. We just need some tests. Thanks so much. |
|
Oh boy!! |
|
Could you merge master/rebase? |
d22780d to
9be0032
Compare
|
@joostdevries it's now up to date with master. Haven't had time to work on persisting to localStorage yet |
f303637 to
a4254c2
Compare
96c7a74 to
3ee79b6
Compare
3ee79b6 to
735ed6a
Compare
|
Added some tests and support for persisting your settings to localStorage |
|
yay :) |
|
@HeroicEric This is awesome. Thanks! 👍 |
Add support for vim, emacs, and sublime key maps
|
the vim mode doesn't appear to have some of the text block support, the example at http://ace.c9.io/build/kitchen-sink.html has @HeroicEric thoughts? |
|
@stefanpenner I think that's using a totally different editor Ace while ember-twiddle is set up with CodeMirror. We could look into switching maybe but we'd probably want to do a feature comparison to see what we'd be trading. It also looks like there is a Vim Mode API for Codemirror's vim config that we can maybe tweak |
oh for some reason i thought it was ace. |
|
can confirm http://codemirror.net/demo/vim.html has the text-block support, i'll see if i can figure out if its an option or something. |
|
it appears the only config they are using is: |
|
@stefanpenner I can look into it later. It's possible that it's an option not related to vim specifically |
fixes #48
Right now ember-twiddle is dependent on a fork of ivy-codemirror until IvyApp/ivy-codemirror#5 is merged in.This is additionally dependent on IvyApp/ivy-codemirror#7 being merged, which adds support for importing the additional key maps. It is currently working while using my fork that includes the changes in both of those PRs but could also be made to work by manually importing those key map files via bower.It would probably also be cool to persist these settings somewhere but I'm not sure where you would want that done. Maybe in localStorage or a specially named gist?