Merged
Conversation
Contributor
|
This always annoyed me. 👍 |
Member
|
does not fix it for me on dev |
Member
There was a problem hiding this comment.
you need to apply this on the input element itself, not the wrapper.
Contributor
Author
|
@joostdevries Seems that somewhere you have a * { box-sizing: border-box } on canary that I don't have on my local copy of master. So it inherited for me, but not for you. Why don't we have the same styles? Anyway, fixed. |
Contributor
Author
There was a problem hiding this comment.
tabs vs spaces. the usual. Looked fine in WebStorm.
Member
There was a problem hiding this comment.
maybe convert the entire file to spaces to avoid messiness.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following issue on canary: