Update ember-cli-jstree to fix 'calling set on destroyed object' errors in Chrome#282
Merged
Gaurav0 merged 3 commits intoember-cli:masterfrom Nov 17, 2015
Merged
Conversation
…nto fix_timeouts
…nto set_destroyed
Gaurav0
changed the title
|
@Gaurav0 I checked out the 'set_destroyed' branch and ran the tests twice. The tree tests seem to be passing every time. Not sure why they would fail sporadically. |
Gaurav0
added a commit
that referenced
this pull request
Nov 17, 2015
Update ember-cli-jstree to fix 'calling set on destroyed object' errors in Chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Some of the jstree related tests still sporadically fail in Chrome. @ritesh83 can you please look into this?