Make router.js optional; add router blueprint (fixes issue #55)#56
Merged
joostdevries merged 3 commits intoember-cli:masterfrom Jul 16, 2015
Merged
Conversation
Contributor
There was a problem hiding this comment.
warn or error? Will support for routerless go away, if so when will it go away
Contributor
Author
There was a problem hiding this comment.
@joostdevries @alexspeller Care to weigh in?
Contributor
Author
There was a problem hiding this comment.
Actually, I have a better idea. If we added a blueprint, we could make router.js permanently optional.
Gaurav0
changed the title
Member
|
@Gaurav0 thanks! Ultimately I think we can refactor this to be a bit more abstract+concise:
|
joostdevries
pushed a commit
that referenced
this pull request
Jul 16, 2015
Make router.js optional; add router blueprint (fixes issue #55)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows existing Ember Twiddle gists without a router.js to continue to work by making router.js optional. Users can now add a router through a blueprint. This also lets them conveniently reset the router by deleting and adding a new one.
Fixes issue #55