Conversation
Member
|
This looks great, and a definite improvement! I think a future revision could even use sourcemap information to help narrow things down even further. |
| * Try to show a useful error message if we're not able to start the user's | ||
| * app in FastBoot. | ||
| */ | ||
| printError: function(e) { |
Contributor
There was a problem hiding this comment.
this function looks pretty complicated, it is likely a good idea to have unit tests covering it.
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
Add dev script to make tracing easier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous commit caused stack traces to not be printed if there was an error while loading an app, making debugging much harder.
This commit reintroduces the stack trace to the logged output. It also tries to parse the stack trace and provide more helpful output for people who are not familiar with Ember's internals.
Example with exception from an addon:
Example with exception from the app:
