Skip to content

Make isFastBoot writeable (again)#352

Merged
rwjblue merged 1 commit intoember-fastboot:masterfrom
jasonmit:isFastBoot-writeable
Feb 10, 2017
Merged

Make isFastBoot writeable (again)#352
rwjblue merged 1 commit intoember-fastboot:masterfrom
jasonmit:isFastBoot-writeable

Conversation

@jasonmit
Copy link
Copy Markdown
Contributor

@jasonmit jasonmit commented Feb 9, 2017

Discussion: #303

There is a need to allow this prop to be stubbed, currently that is not easy and would involve stubbing self.Fastboot which isn't great since it cannot be reset.

/cc @bcardarella

@jasonmit jasonmit changed the title Make isFastBoot writeable Make isFastBoot writeable (again) Feb 9, 2017
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Feb 10, 2017

not ok 14 PhantomJS 2.1 - Unit | Service | fastboot in the browser: isFastBoot
    ---
        actual: >
            null
        stack: >
            http://localhost:7357/assets/tests.js:196:24
            exports@http://localhost:7357/assets/vendor.js:136:37
            requireModule@http://localhost:7357/assets/vendor.js:28:25
            require@http://localhost:7357/assets/test-support.js:4710:14
            loadModules@http://localhost:7357/assets/test-support.js:4702:21
            load@http://localhost:7357/assets/test-support.js:4732:33
            http://localhost:7357/assets/test-support.js:4615:22
        message: >
            Expected 3 assertions, but 2 were run
        Log: |
    ...

@jasonmit jasonmit force-pushed the isFastBoot-writeable branch from 6d76541 to 9923b5e Compare February 10, 2017 00:54
@jasonmit
Copy link
Copy Markdown
Contributor Author

@rwjblue whoops, fixed.

@jasonmit jasonmit force-pushed the isFastBoot-writeable branch from 9923b5e to b189f32 Compare February 10, 2017 00:55
@rwjblue rwjblue merged commit 2ade9ef into ember-fastboot:master Feb 10, 2017
@rwjblue
Copy link
Copy Markdown
Member

rwjblue commented Feb 10, 2017

Thanks @jasonmit!

@jasonmit jasonmit deleted the isFastBoot-writeable branch February 10, 2017 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants