Skip shoebox elements when clearing pre-rendered elements

[paulgoetze]

Addresses the shoebox issue described in #565 (comment).

[chrism]

Hi @paulgoetze

I've come back to trying to use the shoebox and thanks to this PR I've managed to get it working!

The only thing is, for me, your branch gives me this error...

jQuery.Deferred exception: Array.indexOf is not a function TypeError: Array.indexOf is not a function
...
clear-double-boot.js:31 Uncaught TypeError: Array.indexOf is not a function
at clearHtml (clear-double-boot.js:31)

Which comes from this line

while (nextNode && nextNode !== endMarker && Array.indexOf(shoeboxNodes, nextNode) === -1)

But, by changing it to

while (nextNode && nextNode !== endMarker && !Array.from(shoeboxNodes).includes(nextNode))

It seems to work perfectly.

Should I submit a new PR to supersede this one, or would you prefer to update this one?

Thanks again.

[paulgoetze]

Hey, @chrism, thanks for testing. I’ll update this PR. No need to create a new one.

[paulgoetze]

The inclusion check is updated to use !Array.from().includes() now.

[kratiahuja]

Hi @paulgoetze Thanks for the PR, tests are failing due to a build issue. Could you please help look at it?

[kratiahuja]

Tests are failing due to warp-drive-data/warp-drive#5760. THis should be fixed. Let's re-run the job?

[paulgoetze]

Sure, I’ll rebase against upstream master.

[chrism]

This is great and fixes the shoebox clearing issue, it would be great to get merged!

[paulgoetze]

@kratiahuja Just curious: Anything that is holding back this PR from being merged? Do you need help with anything related? Seems to be a rather crucial thing since the latest package version is not working with shoebox data.

[kratiahuja]

@paulgoetze sorry nothing blocking it. I just didn't get back to this PR. I'll review now and merge and release today.

[kratiahuja]

v2.0.3 has been published.

[chrism]

Thank you!

[paulgoetze]

Great, thanks @kratiahuja! 🎉