Refactor to use @glimmer/components; Drop Node 10 support; Drop Ember < 3.16;#94
Merged
rwjblue merged 27 commits intoember-fastboot:masterfrom May 26, 2021
Merged
Conversation
|
@ronco is this something you'd be ok to merge? |
|
@rwjblue is this something you could merge/release? |
rwjblue
requested changes
May 24, 2021
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Looks good overall, I left a couple inline comments to address but should hopefully be pretty minor tweaks.
Contributor
Author
|
@rwjblue I believe it should be good now |
rwjblue
reviewed
May 24, 2021
Contributor
Author
|
we have both a package-lock.json and a yarn.lock. It's probably my fault I run |
added 5 commits
May 24, 2021 15:39
* Move `<HeadContent />` -> `<Head />` (relying on colocation) * Turn into a `@glimmer/component`
Member
|
Ya, I've fixed that specific issue (moved to using npm only) and finally got CI to run properly again, but need to spend some time to dig into why things are failing to render as expected. I think it might be due to |
Do not transpile for `IE11` (in CI or production). See embroider-build/embroider#731
Member
|
Yippie!!! Looks like that last change finally finished the last of the CI scenarios off. |
rwjblue
approved these changes
May 26, 2021
rwjblue
changed the title
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes:
@glimmer/componentusage