Fix to run all tests#208
Merged
kratiahuja merged 1 commit intomasterfrom Dec 17, 2018
Merged
Conversation
Currently only one test (fastboot-dependencies) is running on master. This PR fixes to run all tests. Will be adding revelant eslint plugins as next PR so this doesn't happen in future.
Turbo87
approved these changes
Dec 17, 2018
Contributor
|
good catch! 👍 we should probably use something like https://github.com/lo1tuma/eslint-plugin-mocha/ to prevent this from happening in the future |
Contributor
Author
|
Yup I am exactly working on that next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only one test (fastboot-dependencies) is running on master. This PR fixes to run all tests. Will be adding revelant eslint plugins as next PR so this doesn't happen in future.
cc: @rwjblue