Add unit tests for Ember application boot-time errors#77
Merged
danmcclain merged 1 commit intoember-fastboot:masterfrom Aug 31, 2016
Merged
Add unit tests for Ember application boot-time errors#77danmcclain merged 1 commit intoember-fastboot:masterfrom
danmcclain merged 1 commit intoember-fastboot:masterfrom
Conversation
Member
|
Seems good to me... |
Member
|
I would remove the map, seems unnecessary |
Author
|
Sure. I just copied over one of the base fixture apps so they were already there. |
arjansingh
force-pushed
the
boot-promise-errors
branch
from
88ed0b7 to
ac50148
Compare
Author
|
Removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a simple test that calls
windowand causes theApplicationInstancebooting to fail.I wrote this to test my hypothesis in #76 but as I said there, I think that issue might be higher up the dependency chain.
Since this test passes, and does test for a valid regression case, I thought I'd offer it back as a PR.