Skip to content

Conversation

@cibernox
Copy link
Contributor

Before:

File sizes:
 - dist/assets/dummy-85b90b99235e74788ee6f2d9e1a8ae0f.js: 154.27 KB (33.92 KB gzipped)
 - dist/assets/vendor-5e6d3ca90736b58a05177e7786ece4f5.js: 1.67 MB (442.97 KB gzipped)

After:

File sizes:
 - dist/assets/dummy-85b90b99235e74788ee6f2d9e1a8ae0f.js: 154.27 KB (33.92 KB gzipped)
 - dist/assets/vendor-1ae6d4df0c293cba4de9787f665208aa.js: 1.58 MB (413.65 KB gzipped)

This saves 29,32KB after gzip.

@cibernox cibernox force-pushed the remove-jquery-and-shims branch from 46de2f7 to 4ac88f7 Compare March 18, 2018 11:19
@cibernox
Copy link
Contributor Author

cibernox commented Mar 18, 2018

@rwjblue I may have hit a bug in ember-source-channel-url. If you check this travis build (https://travis-ci.org/ember-learn/ember-cli-addon-docs/builds/354966426?utm_source=github_status&utm_medium=notification), you can see in the log of the failed scenario that release is 2.18.2

@rwjblue
Copy link
Contributor

rwjblue commented Mar 18, 2018

Ya, @runspired just mentioned the same thing to me yesterday (and filed an issue in ember-source-channel-url for it). I’m not quite sure what’s going on yet but will dig in soon...

@cibernox cibernox force-pushed the remove-jquery-and-shims branch from 4ac88f7 to 76c112d Compare March 19, 2018 11:51
@rwjblue
Copy link
Contributor

rwjblue commented Mar 19, 2018

FYI - the issue wasn't in ember-source-channel-url (but was an issue with the release branch of emberjs/ember.js not kicking off builds). Should be resolved now...

@cibernox
Copy link
Contributor Author

After a rebuild, this is green now!

@pzuraq pzuraq merged commit 42ba5a5 into ember-learn:master Mar 19, 2018
@pzuraq
Copy link
Contributor

pzuraq commented Mar 19, 2018

Awesome, thanks for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants