Support ES6 syntax#416
Conversation
4d614fa to
0676bba
Compare
|
Now this PR is ready to review. @stefanpenner @rwjblue |
ef8d97e to
53ad192
Compare
|
+1 |
|
Awesome, do you think we'll be able to support |
|
Yes, It is important but now it doesn't be supported. |
|
Looking forward to seeing this land! 👍 |
There was a problem hiding this comment.
lets try to align this with ember-cli's conventions, all files/folders in the app are dasherized
53ad192 to
5c22d1c
Compare
|
I'm now working on another branch because I have to consider implementation carefully. |
5c22d1c to
92f84b6
Compare
|
Updated to add the following to this PR's description:
|
|
All TODO things are done. @stefanpenner @rwjblue |
|
Hi @tricknotes, awesome work! Do you have a fork with this change? I would like to try, this definitely will help to migrate to ember-cli. |
|
Any update for this? |
This commit changes generator's behavior, but doesn't break anything.
* `.js.coffee` -> `.coffee` * `.js.es6` -> `.module.es6`
To prevent the following error: ``` Java::JavaLang::OutOfMemoryError: Java heap space ``` ref: jruby/jruby#1320
051d326 to
3c007e2
Compare
Abstract
We can use es6 syntax on asset pipeline.
This way is the same as ember-cli .
The setting specified ember-rails is the followings:
my-app.js.es6application.jsI think the following benefits are there for ember-rails users:
TODO
javascript-engine=es6