Skip to content

Support ES6 syntax#416

Merged
tricknotes merged 25 commits into
masterfrom
es6-module-syntax
Feb 9, 2016
Merged

Support ES6 syntax#416
tricknotes merged 25 commits into
masterfrom
es6-module-syntax

Conversation

@tricknotes

Copy link
Copy Markdown
Member

Abstract

We can use es6 syntax on asset pipeline.
This way is the same as ember-cli .

The setting specified ember-rails is the followings:

  • my-app.js.es6

    //= require ember-rails/application
    //= require_tree
    //= require_self
    
    import App from 'ember-rails/application';
    
    App.create();
  • application.js

    // = require ./my-app
    
    require('my-app');

I think the following benefits are there for ember-rails users:

  • It supports ES6 (current Ember way) in ember-rails.
  • It helps migrating from ember-rails ls to Ember CLI

TODO

  • Support es6 module syntax
  • Support generator option javascript-engine=es6
  • Add test
  • Write how to use es6 module syntax to README
  • Write about how to use multiple app
  • Change ES6 transpiler

@tricknotes tricknotes force-pushed the es6-module-syntax branch 3 times, most recently from 4d614fa to 0676bba Compare December 23, 2014 11:53
@tricknotes tricknotes changed the title WIP: Support ES6 module syntax Support ES6 module syntax Dec 23, 2014
@tricknotes

Copy link
Copy Markdown
Member Author

Now this PR is ready to review.

@stefanpenner @rwjblue
Could you give me a feedback +1/-1 ?

@ashrafmajdee

Copy link
Copy Markdown
Contributor

+1

@bradleypriest

Copy link
Copy Markdown
Member

Awesome, do you think we'll be able to support .js.coffee.es6 or .js.es6.coffee at some point as well?

@tricknotes

Copy link
Copy Markdown
Member Author

Yes, It is important but now it doesn't be supported.
I'll support it at some early date.

@mmun

mmun commented Jan 20, 2015

Copy link
Copy Markdown
Member

Looking forward to seeing this land! 👍

Comment thread README.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets try to align this with ember-cli's conventions, all files/folders in the app are dasherized

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed 😉

@tricknotes tricknotes changed the title Support ES6 module syntax WIP: Support ES6 module syntax Jan 29, 2015
@tricknotes

Copy link
Copy Markdown
Member Author

I'm now working on another branch because I have to consider implementation carefully.
When it is decided, I'll update this PR.

@tricknotes tricknotes changed the title WIP: Support ES6 module syntax Support ES6 Aug 29, 2015
@tricknotes tricknotes changed the title Support ES6 Support ES6 syntax Aug 29, 2015
@tricknotes

Copy link
Copy Markdown
Member Author

Updated to add the following to this PR's description:

I think the following benefits are there for ember-rails users:

  • It supports ES6 (current Ember way) in ember-rails.
  • It helps migrating from ember-rails ls to Ember CLI

@tricknotes

Copy link
Copy Markdown
Member Author

All TODO things are done.

@stefanpenner @rwjblue
Could you review again?

@tulios

tulios commented Nov 29, 2015

Copy link
Copy Markdown

Hi @tricknotes, awesome work! Do you have a fork with this change? I would like to try, this definitely will help to migrate to ember-cli.

@mufid

mufid commented Dec 11, 2015

Copy link
Copy Markdown

Any update for this?

tricknotes added a commit that referenced this pull request Feb 9, 2016
@tricknotes tricknotes merged commit 1c4457b into master Feb 9, 2016
@tricknotes tricknotes deleted the es6-module-syntax branch February 9, 2016 15:28
@tricknotes tricknotes restored the es6-module-syntax branch February 9, 2016 15:28
Eric-Guo added a commit to Eric-Guo/ember-crm that referenced this pull request Feb 10, 2016
Eric-Guo added a commit to Eric-Guo/ember-crm-js that referenced this pull request Feb 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants