require() statement remains in compiled ember.js

[craigteegarden]

The change occurred in d4e6a5c specifically here:

ember.js/packages/ember-handlebars-compiler/lib/main.js

Line 15 in d4e6a5c

Handlebars = require('handlebars');

if(!Handlebars && typeof require === 'function') {
  Handlebars = require('handlebars');
}

This require statement is present in the ember.js file after being built. This interferes with the grunt-based build system I'm using, specifically the neuter plugin (this is based off of https://github.com/trek/ember-todos-with-build-tools-tests-and-other-modern-conveniences/).

The neuter plugin detects the require() statement and tries to replace it with a local file named handlebars.js which doesn't exist, causing:

if(!Handlebars && typeof require === 'function') {
  Handlebars = 

})();

which then breaks when loaded into a browser.

Is ember-handlebars-compiler supposed to be included in the compiled version of ember.js? Is there a way to not include this statement/module in the final output? I currently can work around this by editing the file to remove the require statement manually.

[wagenet]

@machty can you look into this?

[machty]

Hmm, not sure what to suggest here. The node-compatible ember-template-compiler distro needs to be able to have Handlebars be swappable with whatever version's in node_modules. It seems like the safest, most generalized form of the neuter filter ought to just replace missing require files with "" or something that's still valid javascript but will throw in the runtime if actually accessed... maybe the change belongs there?

[craigteegarden]

@trek what do you think?

[trek]

I'm leaning towards agreement with @machty. We need to support multiple execution environments for Handlebars and neutering as a strategy is kind of squatting on require territory. I don't think I'd want to silently ignore missing required files while neutering in development, but possibly if you passed an -f flag, or we could make it a configurable option (ignoreMissingFiles), or a list of required paths you should silently ignore. Either way, this is an issue with https://github.com/trek/grunt-neuter and you should go bother that guy.