Revert QP changes from LTS 2.4. #13600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbbfe4a.
Member
Author
|
Note: this targets the lts-2-4 branch |
rwjblue
force-pushed
the
remove-qp-breakage
branch
2 times, most recently
from
e86410f to
3573f1b
Compare
…ransition" This reverts commit 7460b68.
rwjblue
force-pushed
the
remove-qp-breakage
branch
from
3573f1b to
be80e67
Compare
This was referenced Jun 10, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this in depth in a recent core team call, and decided that we should revert these changes from the LTS branch. They fix a number of issues that existed since 2.0.0, but they also introduced some new failures. We will continue to iterate and address the new failures in 2.7+, but we should strive to ensure the latest LTS patch release is usable for folks.
Sadly, reverting these commits means that anyone using 2.4.5 and relying on the bugs that were originally being fixed will now have an issue on 2.4.6 (when released). I agree that this is annoying, but I think it is much better to keep the issues that are present on 2.4 branch consistent with the earlier point releases.