Merged
Conversation
Contributor
📊 Package size report -0%↓
🤖 This report was automatically generated by pkg-size-action |
Contributor
|
blueprint errors look legit --- js extensions are now gjs and such |
renovate
bot
force-pushed
the
renovate/lock-file-maintenance
branch
4 times, most recently
from
90256b8 to
5db56ff
Compare
Contributor
|
@copilot why do we have a failure in the blueprint tests -- which dep caused that? |
Contributor
|
@NullVoxPopuli I've opened a new pull request, #21199, to work on those changes. Once the pull request is ready, I'll request review from you. |
renovate
bot
force-pushed
the
renovate/lock-file-maintenance
branch
from
5db56ff to
fd4d111
Compare
Contributor
|
@copilot look at the investigation in #21199 (comment) and fix the blueprint tests that are currently failing |
Contributor
|
@NullVoxPopuli I've opened a new pull request, #21200, to work on those changes. Once the pull request is ready, I'll request review from you. |
10 tasks
- Update fixtures/component-test/app.gjs and addon.gjs to use parameterized <%= =%> templates for component, componentInvocation, and testDescription - Update component-test-test.js to expect .gjs files and pass testDescription - Update component-test.js to expect .gjs files in strict mode; add --loose flag to @ember/component test; update Foo::XFoo → XFoo componentInvocation - Update route-test.js: add strictRouteTemplate() helper; update all .hbs template expectations to .gjs with strictRouteTemplate(); update application.gjs removeSync; keep --loose and --route-authoring-format loose tests as-is (explicit loose mode) Root cause: ember-cli 6.11.0 now defaults to strict (GJS/template-tag) mode when creating new apps, so blueprints now generate .gjs files by default. Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
…st.js - Remove glimmerComponentContents and templateOnlyContents which are no longer referenced (components now use fixture() calls instead of inline strings) - Run prettier on route-test.js to fix formatting issues Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
When fixture() is called without options it returns a chai file object,
not a string. Calling .replace() on it throws a TypeError. Pass an empty
options object {} to force the helper to return a string so .replace()
works correctly for the class-name substitution.
Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Since --strict is now the default, add tests that explicitly pass --loose to verify .js files are still generated correctly in each context: - in app: component-test foo --loose → foo-test.js (app.js fixture) - in app: component-test x-foo --unit --loose → x-foo-test.js (unit.js) - in addon: component-test foo --loose → foo-test.js (addon.js fixture) - in addon: component-test foo --unit --loose → foo-test.js (addon-unit.js) - in in-repo-addon: component-test foo ... --loose → foo-test.js (app.js) - in in-repo-addon: component-test x-foo ... --unit --loose → x-foo-test.js Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
update blueprint tests for ember-cli 6.11.0 strict/GJS mode defaults
NullVoxPopuli
approved these changes
Mar 6, 2026
Contributor
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
🔧 This Pull Request updates lock files to use the latest dependency versions.
Configuration
📅 Schedule: Branch creation - "before 4am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.