[FEATURE ember-routing-multi-current-when] link-to currentWhen can handle multiple routes

[gpoitch]

Expanding upon the link-to helper's currentWhen property to support multiple routes, using a pipe delimiter.

{{#link-to 'about' currentWhen='about|team'}}About{{/link-to}}

[rwjblue]

@gdub22 - Could you update the docs (here) to reflect your changes?

Also, a single space seems like a more obvious separator choice to me, but lets wait to see what the core team folks think before changing it...

[stefanpenner]

this would also be a feature, and should be marked and flagged as such. see: http://emberjs.com/guides/configuring-ember/feature-flags/

[wagenet]

@gdub22 can you add the tag as @stefanpenner requested? We'll also need to discuss this with the core team.

[gpoitch]

Feature flagged

[hyderali]

@gdub22 Why was this closed ?

[gpoitch]

@hyderali Accidentally got blown away during some housekeeping. Can redo if interested.

[hyderali]

@gdub22 , Yeah, in need of this in my current project, and will be of great help, if this comes built-in.

[Kerrick]

Also would find incredibly useful, love it if this could be included in Ember.js core.

[selvagsz]

ping @gdub22 I believe this a useful addition to ember-core.

[gpoitch]

@hyderali @Kerrick @selva-g recreated.

[selvagsz]

Ping @wagenet @rjackson
Looks to be a long-pending thread. Any updates here ?

[wagenet]

@gdub22 This needs to be rebased.

[gpoitch]

@wagenet @selvagsz rebased

[wagenet]

@rjackson Did this get discussed in core?

[alexspeller]

👍 This would be awesome

[GetContented]

There's something un-HTML-like about camelBack case: CSS sets the precedence for mulitple word attribute names, really. For example: word-wrap, or border-radius, etc. Also agree with @rjackson that space would be a better sub-string delimeter within attribute value (mulitple CSS classnames sets the precedence there).

[alexspeller]

@JulianLeviston agreed, space is way more consistent with other things in ember whereas the pipe delimiter AFAIK is not used anywhere else.

[gpoitch]

I don't see how that CSS argument applies to this feature. My original thought is the pipe helps represent an 'or' operator, although it actually reads as a bitwise operator. One thing to note is that a route name with a space is actually valid. So is a pipe, but probably far less commonly used. Definitely all for consistency.

[alexspeller]

@gdub22 yes I also don't see how the css argument applies. Routes are (generally) camelcased, and the currentWhen property accepting multiple routes doesn't apply here.

I didn't realize that routes with spaces in were valid. Perhaps they shouldn't be valid?

[GetContented]

The argument is that this is a template helper, so similar rules to HTML should apply, IMHO. BTW, no disrespect intended, gdub22. Your approach is very understandable and one can easily see why you chose what you chose.

[alexspeller]

@JulianLeviston not sure if you mean the rules should apply to the name "currentWhen" or the arguments "fooRoute|barRoute", however neither makes sense - the name of the property is a javascript property that you are setting on the view and the arguments are route names. If you disagree about either of these naming conventions in ember this ticket is not the right place to argue for a change because those conventions apply throughout ember and handlebars, not just to this helper.

[gpoitch]

@JulianLeviston no worries :) currentWhen is actually already implemented in the ember api, this just expands upon it.

All unicode characters seem to be valid in route names.

[GetContented]

all good :)

[hyderali]

@rjackson , any updates on this ?

[eniolopes]

I would love to be able to use this. 👍

[hyderali]

@gdub22 Can you rebase this branch ?
@rjackson Has this been discussed in any of the core team meeting ?

[goto-bus-stop]

Just a hunch regarding the route list separator—

Handlebars.helper('list', function (...items, options) { return items; });

{{#link-to 'about' currentWhen=(list 'about' 'team')}}About{{/link-to}}

[rwjblue]

I'm generally 👍 on this. @gdub22 can you rebase? Will merge unless @machty disagrees, but it will still need to wait on +1/-1 from the rest of core before being enabled by default.

[machty]

Happy to merge and deliberate while it remains behind a feature flag.

[gpoitch]

Working on rebasing... that code changed a lot.

[rwjblue]

@gdub22 - Yeah, the query-params stuff likely affected this area quite a bit. Sorry for taking so long in getting back to you, but thanks for working on this.

[gpoitch]

@rjackson @hyderali
rebased.

[rwjblue]

Thanks!

[code-jongleur]

Following the EmberJS Change Log, the feature is included since EmberJS 1.6.0 release, right? I tried it. When I setup my .hbs template like in the first post {{#link-to 'about' currentWhen='about|team'}}About{{/link-to}}, I get an error message "Uncaught Error: There is no route named about|team". Ember doesn't seem to be able to resolve the routes correctly or to interpret them as two routes. Neither a pipe, a blank as a separator nor (list 'about' 'team') is working here. Did there anything change with the syntax in the meanwhile. I am a little bit confused. I am using EmberJS 1.6.1. Thank you very much for any hints!

[gpoitch]

@coachTomato This feature is not in 1.6.0. You have to use a canary build and enable the feature flag

[code-jongleur]

Ah, ok, I'll try that.

[tomdale]

We discussed this at the core team meeting. We are go on the feature, but would like to change the syntax to be space-delimited instead of pipe-delimited.

[tomdale]

@rwjblue will work on the patch this weekend when prepping the new releases.

[code-jongleur]

@tomdale: Great news. I have no problem to change the syntax to space-delimited in my code.

[Kerrick]

👍 Space-delimited seems more consistent with Ember's other features.

[trek]

@gdub22 can you update based on @tomdale's feedback?

[rwjblue]

@trek - This was already done, and is included in 1.8.0-beta.1 (with a space delimited list).

[rwjblue]

Was updated and enabled in #5387.