Skip to content

[FEATURE ember-runtime-proxy-mixin]#5156

Merged
rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue:object-proxy-mixin
Jul 14, 2014
Merged

[FEATURE ember-runtime-proxy-mixin]#5156
rwjblue merged 1 commit intoemberjs:masterfrom
rwjblue:object-proxy-mixin

Conversation

@rwjblue
Copy link
Copy Markdown
Member

@rwjblue rwjblue commented Jul 13, 2014

Moves most functionality of Ember.ObjectProxy into a mixin that use used for Ember.ObjectProxy, but can also be used on its own (for mixin into custom objects).

@stefanpenner
Copy link
Copy Markdown
Member

  • 1

feature

Also, @krisselden was thinking of making "content" property name configurable. But that may be a future PR

@rwjblue rwjblue changed the title Add Ember.ObjectProxyMixin. [FEATURE ember-runtime-object-proxy-mixin] Jul 13, 2014
@rwjblue
Copy link
Copy Markdown
Member Author

rwjblue commented Jul 13, 2014

Feature flagged the export.

Ember.ObjectProxy will still use the new mixin itself, but the new mixin will only be exported if the flag is on.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be called ProxyMixin?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good (doesn't have anything to do with Objects directly anymore). Updated.

Moves most functionality of Ember.ObjectProxy into a mixin that use used
for `Ember.ObjectProxy`, but can also be used on its own (for mixin into
custom objects).
@rwjblue
Copy link
Copy Markdown
Member Author

rwjblue commented Jul 13, 2014

Rebased

@rwjblue rwjblue changed the title [FEATURE ember-runtime-object-proxy-mixin] [FEATURE ember-runtime-proxy-mixin] Jul 14, 2014
rwjblue added a commit that referenced this pull request Jul 14, 2014
[FEATURE ember-runtime-proxy-mixin]
@rwjblue rwjblue merged commit 18dd58d into emberjs:master Jul 14, 2014
@rwjblue rwjblue deleted the object-proxy-mixin branch July 14, 2014 15:54
@igorT
Copy link
Copy Markdown
Member

igorT commented Oct 13, 2014

This seems to leave ArrayProxy in the cold? Maybe call it ObjectProxyMixin instead?

@igorT
Copy link
Copy Markdown
Member

igorT commented Oct 13, 2014

Saw it was removed :( :(

@devinus
Copy link
Copy Markdown
Member

devinus commented Dec 26, 2017

How is this imported using the new @ember imports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants