fixing getting-started bug when editing todo

[izhan]

Editing todos throws an error whenever the change is confirmed by using a newline (Enter). In particular, it throws the error

Uncaught Error: Attempted to handle event 'willCommit' on <Todos.Todo:ember270:2> while in state root.loaded.updated.inFlight.

For the final Todo (Replacing the Fixture Adapter with Another Adapter), it throws the error

Uncaught Error: Attempted to handle event 'willCommit' on <Todos.Todo:ember272:oumdk> while in state root.deleted.saved.

when you attempt to delete a todo by editing the item to be blank. This error throws future errors in some cases such as Assertion failed: calling set on destroyed object, making the todo list unable to function. Note that this bug does not occur when one confirms an edit by clicking somewhere out of the textfield.

This bug occurs because when newline triggers an edit or removal of a todo, acceptChanges is called a second time due to the textfield being focused out. This may or may not be intended behavior -- PR fixes this and all JSBins by checking whether it is still in edit mode.

[trek]

LGTM. The onc last step is updating the code example repo and interactive rebasing, and adding links to new SHAs for the diff links: https://github.com/trek/website/commit/610fc33692dd3f9767a3f341ac295cf633d919e0

[izhan]

@trek just sent a PR to the code-sample and added a few unrelated typo fixes to the website. Can you please clarify what you mean by "adding links to new SHAs for the diff links"?

[trek]

Since you rebased interactively, the SHAs of those later commit is now different. Each step links to a diff on github by SHA. Those links will be broken.

[izhan]

Got it. Added and squashed that change into the first commit. Anything else?

[trek]

Looks good to me. I'll need to find a time to manually the repo changes and then publish.

[izhan]

sounds good -- lemme know if you need any help.

[izhan]

@trek Any updates on this?

[tbassetto]

I am in the process of learning Ember.js and I was confused by the fact that the Getting Started guide makes your create an app throwing errors in the console. Is it possible for someone to finally merge this PR? As a newcomer it's really not clear why this error is happening (it took me a while to find this PR and a related issue).

[trek]

The new starting guide will not be based on TodoMVC.