Build system - #1
Merged
Merged
Conversation
…k build tree, esp FORTRAN tests - Drop requirement for (rather old) starlink fork of automake - Brought in my own replacements for the bare minimum set of routines from Starlink libraries needed for the tests; written in C which I'm more comfortable with, but with gfortran name mangling applied, following the conventions from the macros in f77.h; some of this is probably still buggy but the tests pass - Bring the Fortran tests more into the automake build system
…ed tests add a Makefile.am in ast_tester and move fortran test definitions there, and hook them properly into automake's test runner Now there are two test suites: ast_tester/ and ast_tests/ I believe this will still all work the same otherwise when building in the Starlink environment but this needs to be confirmed.
default boostrap for out-of-starlink builds Provides some minimal necessary STAR_ m4 macros needed for the build.
within the Starlink build environment Takes further steps (including handling of the default Starlink m4 macros) to separate the 'local' build initiated with bootstrap.local from the standard Starlink build initialized by bootstrap
built by the makefile
libasdf CI workflow but simplified
timj
added a commit
that referenced
this pull request
Aug 31, 2026
The three LaTeX2HTML macros AST uses are defined in LaTeX2HTML 95.1's
html.sty, a copy of which sits in $STARLINK/bin/sst. Cite it rather than
reasoning from first principles, and say exactly where we depart from it:
\htmlref #1 -- as html.sty
\htmladdnormallink #1 -- widened to \href
\htmladdnormallinkfoot #1\footnote{#2} -- widened to \href
\htmlref is byte-for-byte html.sty's definition, so the earlier choice to
render the text and drop the label was right for a better reason than the
one recorded: it is what these documents were written against. The two
link commands drop or plain-print the URL because html.sty targets paper;
these are PDFs with hyperref loaded, so both become live links. Nothing
printed changes either way.
AST uses no other macro from that family -- \htmlref 3248 times,
\htmladdnormallinkfoot 4, \htmladdnormallink 2, and nothing else -- so
three definitions here beat vendoring all 231 lines of html.sty, which
carries no licence statement of its own.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR against my own fork to test CI