i18n(fr): translate 138 missing keys + consistency around media library#2102
Conversation
|
github-actions
Bot
added
review/needs-review
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/auth-atproto
@emdash-cms/blocks
@emdash-cms/cloudflare
@emdash-cms/contentful-to-portable-text
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/plugin-cli
@emdash-cms/plugin-types
@emdash-cms/registry-client
@emdash-cms/registry-lexicons
@emdash-cms/registry-verification
@emdash-cms/sandbox-workerd
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-field-kit
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
![emdashbot[bot]](https://avatars.githubusercontent.com/in/3255304?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approach: this is exactly the right kind of PR for a .po refresh — translation-only, well-scoped, and explicitly about backfilling French strings plus media-library terminology consistency. That scope matches CONTRIBUTING's translation policy, so no architectural concerns.
I reviewed every changed hunk in packages/admin/src/locales/fr/messages.po, traced all media-library related strings in the catalog, and confirmed there are no SQL/API/auth/RTL/source-code changes to consider. Most of the 138 new translations look correct and keep the ICU placeholders/plural forms intact. I did not run the locale build, so pnpm locale:compile is unverified.
Two substantive items remain. First, @emdash-cms/admin is a published package, and the repo already contains .changeset/dutch-admin-locale.md as precedent for locale changes, so this PR should include a changeset. Second, the author’s explicit consistency push to "bibliothèque de fichiers multimédias" missed one leftover "bibliothèque multimédia". A third, lighter item is a singular/plural mismatch in the new "Download Backup" heading.
Findings
-
[needs fixing]
packages/admin/src/locales/fr/messages.po:1This PR changes a published package (
@emdash-cms/adminhasprepublishOnly, public npm access, and locale exports), and CONTRIBUTING says every such PR needs a changeset. Precedent exists at.changeset/dutch-admin-locale.mdfor admin locale work. Without a changeset, the French update won't trigger a release.--- "@emdash-cms/admin": patch --- Updates French translations for the admin UI, including new backup and WordPress import strings, and rewords media-library labels for consistency.
-
[needs fixing]
packages/admin/src/locales/fr/messages.po:8548This is the only remaining occurrence of the old/inconsistent "bibliothèque multimédia" phrase after this PR's consistency push to "bibliothèque de fichiers multimédias" for all media-library strings. Anchor it to the same wording.
msgstr "Votre bibliothèque de fichiers multimédias est vide" -
[suggestion]
packages/admin/src/locales/fr/messages.po:2616The source is the singular heading "Download Backup" and the button two lines later is translated as "Télécharger la sauvegarde". The new heading uses the plural "sauvegardes" and reads more like a gerund noun; singular would keep it consistent with its own description and the button.
msgstr "Télécharger une sauvegarde"
There was a problem hiding this comment.
Pull request overview
This PR updates the French (fr) admin UI localization by filling in missing translations and standardizing terminology around the “Media Library” to avoid mixed wording across related screens.
Changes:
- Translates ~138 previously-untranslated French message keys.
- Rewords multiple “Media Library” related strings to use consistent French terminology.
- Adds/updates translations for various Backup, Widgets, and WordPress import UI strings.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
github-actions
Bot
added
review/needs-rereview
There was a problem hiding this comment.
Re-checked the PR head; only packages/admin/src/locales/fr/messages.po changed. This remains a well-scoped translation-only PR backfilling French strings and aligning media-library terminology — exactly the right kind of change for a .po refresh.
The two substantive translation concerns from the prior review are resolved:
- The media-library empty-state string now reads “Votre bibliothèque de fichiers multimédias est vide”, matching the PR’s consistency push.
- The new “Download Backup” heading is now singular “Télécharger une sauvegarde”, consistent with its description and button.
No source-code, SQL, API, authorization, or RTL concerns were introduced, and the added translations preserve ICU placeholders and plural forms.
One item remains unaddressed: this PR changes a published package (@emdash-cms/admin is in .changeset/config.json’s fixed public group and has prepublishOnly), and CONTRIBUTING requires a changeset for every PR that changes a published package’s behavior. Precedent already exists at .changeset/dutch-admin-locale.md for admin locale work. Without a changeset the French update will not trigger a release.
Findings
-
[needs fixing]
packages/admin/src/locales/fr/messages.po:1This PR still does not include a changeset, but it changes a published package.
@emdash-cms/adminis in.changeset/config.json’s fixed public release group, has aprepublishOnlybuild, and CONTRIBUTING says every PR that changes a published package’s behavior needs a changeset. Precedent already exists at.changeset/dutch-admin-locale.mdfor admin locale work.Add a new
.changeset/*.mdfile:--- "@emdash-cms/admin": patch --- Updates French translations for the admin UI, including new backup and WordPress import strings, and rewords media-library labels for consistency.
|
Yeah, sorry. I fixed everything except the changeset because of my last discussion with Matt in #1809 (review) ... It seems the idea was to not add one for updated languages. But, maybe something changed in between? |
github-actions
Bot
added
review/awaiting-author
…ry (emdash-cms#2102) * i18n(fr): translate 138 missing keys + consistency around media library * consistency around media library Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * reword download backup heading --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
What does this PR do?
Type of change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change) (I have a flaky test locallyCannot find element with locator: page.getByText('5,200 installs'), but unrelated to my changes)pnpm formathas been runmessages.pochanges except in translation PRs — a workflow extracts catalogs on merge tomain.AI-generated code disclosure
More or less half/half. Generated with AI then I checked everything in the file before checking what I could with the dev server (and I updated a few things...). Inconsistencies are 100% human finding (and human cause? 😅 ).
Screenshots / test output
N/A