Skip to content

fix(admin): refine typography hierarchy - #2252

Merged
khoinguyenpham04 merged 2 commits into
mainfrom
fix/admin-typography
Jul 27, 2026
Merged

fix(admin): refine typography hierarchy#2252
khoinguyenpham04 merged 2 commits into
mainfrom
fix/admin-typography

Conversation

@khoinguyenpham04

@khoinguyenpham04 khoinguyenpham04 commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes inconsistent typography across the logged-in admin UI while retaining Noto Sans for internationalization. It standardizes page-heading hierarchy, refines Dashboard card headings and metric alignment, improves description and media-library text hierarchy, strengthens subtle-text contrast, preserves native letter spacing across scripts, and adds macOS font smoothing.

Adds regression coverage for Dashboard heading semantics, card alignment, font tracking, and regular-text contrast. There are no API, database, schema, or runtime interface changes.

Related issue: N/A

Type of change

  • Bug fix
  • Feature (requires maintainer-approved Discussion)
  • Refactor (no behavior change)
  • Translation
  • Documentation
  • Performance improvement
  • Tests
  • Chore (dependencies, CI, tooling)

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes
  • pnpm test passes (or targeted tests for my change)
  • pnpm format has been run
  • I have added/updated tests for my changes (if applicable)
  • User-visible strings in the admin UI are wrapped for translation (if applicable). Do not include messages.po changes except in translation PRs — a workflow extracts catalogs on merge to main.
  • I have added a changeset (if this PR changes a published package)
  • New features link to an approved Discussion: N/A — this fixes existing visual inconsistencies and adds no feature.

AI-generated code disclosure

  • This PR includes AI-generated code — model/tool: OpenAI Codex (GPT-5)

Screenshots / test output

  • pnpm typecheck — passed
  • pnpm lint:json — 0 diagnostics
  • pnpm --filter @emdash-cms/admin build — passed
  • oxfmt and Prettier checks — passed
  • Dashboard component tests — 4/4 passed
  • Focused Playwright typography, alignment, and contrast checks — 3/3 passed
  • Manual preview checks covered Dashboard and representative internal pages in English, Japanese, Chinese, Arabic RTL, light theme, and dark theme.

The full 104-file admin run reported one load-sensitive, unrelated SeoPanel timing failure (resets when switching to a different content item). The branch does not touch SeoPanel; its isolated file passes 8/8, while 1,238/1,239 tests passed in the full run.


Try this PR

Open a fresh playground →

A full working EmDash site, deployed from this branch. Each visit gets its own session-scoped sandbox: no login needed and no shared state. Try the admin, edit content, hit the public site.

Tracks fix/admin-typography. Updated automatically when the playground redeploys.

Copilot AI review requested due to automatic review settings July 27, 2026 11:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@changeset-bot

changeset-bot Bot commented Jul 27, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: beb8268

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/cloudflare Patch
@emdash-cms/sandbox-workerd Patch
@emdash-cms/plugin-mcp-smoke Patch
@emdash-cms/fixture-perf-site Patch
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
@emdash-cms/do-demo-site Patch
@emdash-cms/do-solo-demo-site Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added review/awaiting-author Reviewed; waiting on the author to respond area/admin size/L labels Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Scope check

This PR touches 41 files. PRs with a broad scope are harder to review. Please confirm the scope hasn't drifted beyond the intended change.

If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs.

See CONTRIBUTING.md for contribution guidelines.

@pkg-pr-new

pkg-pr-new Bot commented Jul 27, 2026

Copy link
Copy Markdown

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@2252

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@2252

@emdash-cms/auth-atproto

npm i https://pkg.pr.new/@emdash-cms/auth-atproto@2252

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@2252

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@2252

@emdash-cms/contentful-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/contentful-to-portable-text@2252

emdash

npm i https://pkg.pr.new/emdash@2252

create-emdash

npm i https://pkg.pr.new/create-emdash@2252

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@2252

@emdash-cms/plugin-cli

npm i https://pkg.pr.new/@emdash-cms/plugin-cli@2252

@emdash-cms/plugin-types

npm i https://pkg.pr.new/@emdash-cms/plugin-types@2252

@emdash-cms/registry-client

npm i https://pkg.pr.new/@emdash-cms/registry-client@2252

@emdash-cms/registry-lexicons

npm i https://pkg.pr.new/@emdash-cms/registry-lexicons@2252

@emdash-cms/registry-verification

npm i https://pkg.pr.new/@emdash-cms/registry-verification@2252

@emdash-cms/sandbox-workerd

npm i https://pkg.pr.new/@emdash-cms/sandbox-workerd@2252

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@2252

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@2252

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@2252

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@2252

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@2252

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@2252

@emdash-cms/plugin-field-kit

npm i https://pkg.pr.new/@emdash-cms/plugin-field-kit@2252

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@2252

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@2252

commit: beb8268

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-do beb8268 Jul 27 2026, 11:41 AM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-demo-cache beb8268 Jul 27 2026, 11:41 AM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdash-playground beb8268 Jul 27 2026, 11:41 AM

@khoinguyenpham04 khoinguyenpham04 added the bot:review Trigger an emdashbot code review on this PR label Jul 27, 2026

@emdashbot emdashbot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a focused visual bug-fix PR: it standardizes admin page-heading sizes/weight/leading, tightens Dashboard card heading alignment and metric typography, bumps subtle-text contrast in the classic light theme, and adds macOS font smoothing. There are no API, database, or runtime interface changes, and the author added regression tests for heading semantics, card inset alignment, cross-script tracking, and description contrast.

I read the full diff, the changed admin components, the E2E/unit tests, and checked the PR against the repo’s AGENTS.md conventions:

  • Lingui / i18n: All new/changed user-facing strings remain wrapped with t / plural / msg.
  • RTL-safe Tailwind: No physical directional classes (ml-*/mr-*/pl-*/pr-*/text-left/text-right) were introduced; the new layout tests explicitly handle RTL.
  • SQL / API / auth / query counts: No backend changes; no risk to logged-out routes.
  • Changesets: Two patch changesets for @emdash-cms/admin, present-tense and user-oriented.
  • Tests: New unit test checks every dashboard card title is an h2; new Playwright tests check card/heading alignment, preserved normal letter-spacing across scripts, and description contrast.
  • Comments: No reviewer-facing or justification comments added; the one existing explanatory comment block was actually removed.

Static review found no logic bugs, regressions, or convention violations. The implementation aligns with EmDash’s architecture (Kumo + Tailwind + Lingui), and the breadth of file changes is justified by the single stated goal of fixing typography inconsistency. LGTM.

@emdashbot emdashbot Bot removed the bot:review Trigger an emdashbot code review on this PR label Jul 27, 2026
@github-actions github-actions Bot added review/approved Approved; no new commits since and removed review/awaiting-author Reviewed; waiting on the author to respond labels Jul 27, 2026
@khoinguyenpham04
khoinguyenpham04 merged commit f81f720 into main Jul 27, 2026
50 checks passed
@khoinguyenpham04
khoinguyenpham04 deleted the fix/admin-typography branch July 27, 2026 12:01
@emdashbot emdashbot Bot mentioned this pull request Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants