Skip to content

i18n(ko): complete remaining translations#786

Merged
ascorbic merged 1 commit intoemdash-cms:mainfrom
smart-cau:i18n/ko
Apr 27, 2026
Merged

i18n(ko): complete remaining translations#786
ascorbic merged 1 commit intoemdash-cms:mainfrom
smart-cau:i18n/ko

Conversation

@smart-cau
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds Korean translations for the 21 strings still missing in packages/admin/src/locales/ko/messages.po, bringing coverage to 100% (was 1221/1242 ≈ 98%).

The original Korean catalog landed in #592. As the admin UI evolved, 21 new strings were extracted that hadn't been translated yet — additional API token scopes (Settings Manage, Menus Manage, Taxonomies Manage, Read site settings, Update site settings, etc.), setup-wizard / login flow strings (Sign In, Sign in with {0}, Choose how to sign in, Pick any method to create your admin account., Enter your handle to sign in.), taxonomy term feedback (Failed to create term, New {0}, Add new {0}), URL field strings (Web address, Enter a valid URL (e.g. https://example.com)), and generic toasts ({0} updated, Failed to save, Failed to update {0}).

Per the translating guide, enabled: false on ko in packages/admin/src/locales/locales.ts is intentionally left untouched — maintainers flip the flag once coverage is sufficient.

Refs: #748 (Korean language support request), #145 (admin UI i18n), #592 (initial Korean catalog).

Type of change

  • Translation

Checklist

  • I have read CONTRIBUTING.md
  • pnpm typecheck passes
  • pnpm lint passes (0 diagnostics)
  • pnpm test passes (790 admin tests pass)
  • pnpm format has been run
  • I have added/updated tests for my changes (N/A — translation-only)
  • User-visible strings in the admin UI are wrapped for translation (translation-only PR; only messages.po modified, per template note)
  • I have added a changeset
  • New features link to an approved Discussion (N/A — translation, not a feature)

AI-generated code disclosure

  • This PR includes AI-generated code

Translations were drafted by Claude Opus 4.7 (1M context) by analyzing the existing ko/messages.po for established tone and terminology (e.g. Manage관리, Read읽기, update업데이트, handle핸들, URL left as-is), then reviewed string-by-string by the contributor (Korean native speaker). Placeholders ({0}) preserved verbatim. Manually verified in the running admin (demos/simple) by temporarily flipping ko to enabled: true and walking through the API Token Settings page, taxonomy sidebar, schema field editor, and toast notifications, then reverting the flag before commit.

Screenshots / test output

Text-only translation; manually verified as described above.

Adds Korean translations for the 21 strings still missing in
packages/admin/src/locales/ko/messages.po, bringing coverage to 100%.
The locales.ts `enabled` flag is intentionally left as `false` per
the translating guide -- maintainers flip it once coverage is sufficient.

Refs: emdash-cms#748, emdash-cms#145, emdash-cms#592
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 27, 2026

🦋 Changeset detected

Latest commit: 098fe63

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@emdash-cms/admin Patch
emdash Patch
@emdash-cms/auth-atproto Patch
@emdash-cms/cloudflare Patch
@emdash-cms/fixture-perf-site Patch
@emdash-cms/perf-demo-site Patch
@emdash-cms/cache-demo-site Patch
@emdash-cms/auth Patch
@emdash-cms/blocks Patch
@emdash-cms/gutenberg-to-portable-text Patch
@emdash-cms/x402 Patch
create-emdash Patch
@emdash-cms/plugin-embeds Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@github-actions
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
packages/admin/src/locales/ko/messages.po Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@smart-cau
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Apr 27, 2026
Copy link
Copy Markdown
Collaborator

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ascorbic ascorbic enabled auto-merge (squash) April 27, 2026 13:15
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 27, 2026

Open in StackBlitz

@emdash-cms/admin

npm i https://pkg.pr.new/@emdash-cms/admin@786

@emdash-cms/auth

npm i https://pkg.pr.new/@emdash-cms/auth@786

@emdash-cms/blocks

npm i https://pkg.pr.new/@emdash-cms/blocks@786

@emdash-cms/cloudflare

npm i https://pkg.pr.new/@emdash-cms/cloudflare@786

emdash

npm i https://pkg.pr.new/emdash@786

create-emdash

npm i https://pkg.pr.new/create-emdash@786

@emdash-cms/gutenberg-to-portable-text

npm i https://pkg.pr.new/@emdash-cms/gutenberg-to-portable-text@786

@emdash-cms/x402

npm i https://pkg.pr.new/@emdash-cms/x402@786

@emdash-cms/plugin-ai-moderation

npm i https://pkg.pr.new/@emdash-cms/plugin-ai-moderation@786

@emdash-cms/plugin-atproto

npm i https://pkg.pr.new/@emdash-cms/plugin-atproto@786

@emdash-cms/plugin-audit-log

npm i https://pkg.pr.new/@emdash-cms/plugin-audit-log@786

@emdash-cms/plugin-color

npm i https://pkg.pr.new/@emdash-cms/plugin-color@786

@emdash-cms/plugin-embeds

npm i https://pkg.pr.new/@emdash-cms/plugin-embeds@786

@emdash-cms/plugin-forms

npm i https://pkg.pr.new/@emdash-cms/plugin-forms@786

@emdash-cms/plugin-webhook-notifier

npm i https://pkg.pr.new/@emdash-cms/plugin-webhook-notifier@786

commit: 098fe63

@ascorbic ascorbic merged commit e998083 into emdash-cms:main Apr 27, 2026
29 of 31 checks passed
@emdashbot emdashbot Bot mentioned this pull request Apr 27, 2026
0aveRyan pushed a commit to 0aveRyan/emdash that referenced this pull request Apr 27, 2026
Adds Korean translations for the 21 strings still missing in
packages/admin/src/locales/ko/messages.po, bringing coverage to 100%.
The locales.ts `enabled` flag is intentionally left as `false` per
the translating guide -- maintainers flip it once coverage is sufficient.

Refs: emdash-cms#748, emdash-cms#145, emdash-cms#592
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants