feat(frontend): enhance interactive loading states in Fiat Onramp Integration Interface#1237
Merged
Conversation
…e loading states Adds a SEP-0024 hosted-deposit modal (fiat -> Stellar token onramp) that mirrors the existing SEP-0024 withdrawal flow's anchor discovery, SEP-10 auth, and interactive-iframe pattern, wired into the dashboard's quick actions. This module didn't exist in the codebase before, so the focus for this first pass is a fully realized interaction/loading model: distinct states for connecting to the anchor, waiting on a wallet signature, and generating the deposit form, an inline error state that returns the user to the form instead of dead-ending, a skeleton placeholder while the anchor's interactive iframe loads, and disabled/aria-live states throughout so the loading sequence is announced to assistive tech. Note: main currently fails to compile locally (duplicate `themeRef` declaration in src/lib/theme-context.tsx, pre-existing and unrelated to this change), so this was verified via tsc/eslint/vitest rather than a live browser session. Closes emdevelopa#1211 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@Abidoyesimze is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Abidoyesimze Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FiatOnrampModaldriving a SEP-0024 hosted-deposit flow (fiat -> Stellar token), mirroring the existing SEP-0024 withdrawal modal's anchor-discovery / SEP-10 auth / interactive-iframe pattern, wired into the dashboard's quick actions ("Buy / Deposit").aria-livestates throughout so the loading sequence is announced to assistive tech.Note
maincurrently fails to compile locally (next dev500s) due to a pre-existing, unrelated bug insrc/lib/theme-context.tsx(duplicatethemeRefdeclaration from what looks like a botched merge). Verified viatsc/eslint/vitestinstead of a live browser session.Test plan
vitest run src/components/FiatOnrampModal.test.tsx— 7/7 passing (asset selection, full connecting -> auth -> generating -> interactive walk-through, amount pass-through, inline error + recovery, close/reset)tsc --noEmitclean on touched fileseslintclean on touched filesCloses #1211
🤖 Generated with Claude Code