fix(convo): attribute harness-generated turns to the harness actor - #165
Open
akesling wants to merge 1 commit into
Open
fix(convo): attribute harness-generated turns to the harness actor#165akesling wants to merge 1 commit into
akesling wants to merge 1 commit into
Conversation
A harness sometimes emits an assistant message itself — an API error, a rate-limit notice, a timeout — with no model call behind it. Claude Code marks these with a placeholder in message.model, and derive_path took that placeholder at face value: the step landed on an agent: actor naming a string that is not a model, and meta.actors described the harness as if it were one. The actor convention never meant that — agent:<model> is "a model reply, named by the recorded model". Turn now carries a provider-agnostic harness_generated flag (serde-optional, omitted when false, so the wire format stays byte-compatible with producers that predate it), and derive_path keys the tool:<provider> harness actor on it — the same actor the system and other roles already take. The role stays assistant, so the message keeps its place in the transcript; only the attribution changes. agent:unknown is unaffected: "no model recorded" and "no model involved" stay distinguishable. toolpath-claude owns the placeholder: it maps the sentinel to the flag and leaves Turn.model empty, so the string never reaches the shared, provider-agnostic crate. Any provider can mark such turns from whatever signal its own format gives it, without touching shared code. No schema change: agent-coding-session already says agent:<model> names a recorded model, and a placeholder is neither.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deriver bug fix. Independent of the kind work in #164 / #132 — no schema change, no kind version involved.
The bug
A harness sometimes emits an assistant message itself: an API error, a rate-limit notice, a timeout. No model call happens; the accounting is all zeros. Claude Code records a placeholder in
message.modelfor these, and the deriver took that placeholder at face value, producingagent:<placeholder>actors and matchingmeta.actorsentries.The actor convention never meant that. The agent-coding-session actor table has always defined
agent:<model>as "a model reply, named by the recorded model" — a harness notice is not a model reply, and a placeholder is not a recorded model. So this is the deriver contradicting the spec that was already written, not a change to it.These are not rare: sampling real Claude Code sessions, 14 of 40 contained at least one.
The fix
Turngains a provider-agnosticharness_generatedflag (serde-defaulted, so the wire format is unchanged when false). The shared deriver attributes such turns totool:<provider>— the same harness actor that system and other roles already take — while the turn'srolestaysassistant, so the message keeps its place in the transcript.The placeholder spelling stays where the format knowledge belongs:
toolpath-claudeowns the constant and maps it to the flag withmodel: None, so the string never enters the IR. Any other provider can set the flag from whatever signal its own format offers without touching shared code. Repo-wide, the placeholder is now spelled in exactly one file.agent:unknownis unaffected — "no model recorded" and "no model involved" stay distinct outcomes.Testing
Full workspace suite, clippy, rustdoc, and the examples gate green. Coverage: a harness-generated turn takes the harness actor with the role preserved and a
meta.actorsentry carrying provider but no model; a flagged turn's stray model is ignored; an ordinary assistant turn is untouched; a turn with no recorded model still derives asagent:unknown; and the flag round-trips on the wire in both directions.Versioning follows the deriver-behavior-fix precedent (
Derive: resolve duplicate step ids, 2026-07-01):toolpath-convotakes a minor bump because a new public field onTurnbreaks struct-literal construction downstream;toolpath-claudetakes a patch, its public API being unchanged. No CLI bump — no kind URI changes here.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.