fix(keep alive): remove force ping handling #116
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmstone
reviewed
Oct 17, 2023
| case ConnMod:getstat(Sock, [send_oct]) of | ||
| {ok, [{send_oct, Val}]} -> | ||
| OldVal = get(send_oct), put(send_oct, Val), | ||
| OldVal == undefined orelse OldVal == Val; |
Member
There was a problem hiding this comment.
since PING is a one-byte request the correct fix should be to check if OldVal < Val -1 ?
Author
There was a problem hiding this comment.
PINGREQ has more than one byte. If we insist on subtracting the length of the PINGREQ ourselves, it is okay, but the force_ping mechanism is useless. It is simplest to send PINGREQ at a fixed time.
Author
|
您好，您的邮件已经收到，我会及时处理。
如有急事，请电话联系。 by 周子博.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original forced ping logic also counted the PINGREQ packets sent by itself, resulting in only one PINGREQ packet sent in two Keep Alive cycles.