Skip to content

can no longer export with MODULARIZE + closure's goog.module #20163

@walkingeyerobot

Description

@walkingeyerobot

I'm taking emscripten's js output and prepending goog.module('my.closure.namespace'); to the top to more easily integrate it with the rest of my build. However, this broke with #18954 . goog.module defines exports but not module, so previously it was hitting the final case. Once that got deleted, nothing is exported.

I can simply append exports['Foo'] = Foo to the end of my JS file as a workaround. I realize this might be enough of a niche case that emscripten may reasonably choose to not support it, but I thought it was worth reporting anyway.

More info on goog.module here: https://github.com/google/closure-library/wiki/goog.module:-an-ES6-module-like-alternative-to-goog.provide

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions