I'm taking emscripten's js output and prepending goog.module('my.closure.namespace'); to the top to more easily integrate it with the rest of my build. However, this broke with #18954 . goog.module defines exports but not module, so previously it was hitting the final case. Once that got deleted, nothing is exported.
I can simply append exports['Foo'] = Foo to the end of my JS file as a workaround. I realize this might be enough of a niche case that emscripten may reasonably choose to not support it, but I thought it was worth reporting anyway.
More info on goog.module here: https://github.com/google/closure-library/wiki/goog.module:-an-ES6-module-like-alternative-to-goog.provide
I'm taking emscripten's js output and prepending
goog.module('my.closure.namespace');to the top to more easily integrate it with the rest of my build. However, this broke with #18954 .goog.moduledefinesexportsbut notmodule, so previously it was hitting the final case. Once that got deleted, nothing is exported.I can simply append
exports['Foo'] = Footo the end of my JS file as a workaround. I realize this might be enough of a niche case that emscripten may reasonably choose to not support it, but I thought it was worth reporting anyway.More info on
goog.modulehere: https://github.com/google/closure-library/wiki/goog.module:-an-ES6-module-like-alternative-to-goog.provide