Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyncify: identify functions missing from whitelist #9389

Open
Beuc opened this issue Sep 5, 2019 · 2 comments

Comments

@Beuc
Copy link
Contributor

commented Sep 5, 2019

Hi,

As discussed at #9257 (comment) and confirmed at emscripten-discuss it would be useful to identify what function is missing from ASYNCIFY_WHITELIST, in a manner similar to what Emterpreter does (full stack trace when sleeping or resuming inappropriately).
Opening an issue as requested.

This is particularly useful in complex code with indirect calls :)

@Beuc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

In addition, formatting the function names appears to be error-prone (discussion recommends grepping the wasm disassembly) so it would save time to provide function names in a format recognized by ASYNCIFY_WHITELIST, if possible :)

@gabrielcuvillier

This comment has been minimized.

Copy link
Contributor

commented Sep 6, 2019

I agree with this. The current approach I am using is to use Emterpreter first to find out the functions to whitelist at runtime, demangle them, then switch back to ASYNCIFY...

@kripken kripken added the help wanted label Sep 9, 2019

@kripken kripken self-assigned this Sep 11, 2019

@kripken kripken removed the help wanted label Sep 11, 2019

kripken added a commit to WebAssembly/binaryen that referenced this issue Sep 13, 2019
Add asserts in Asyncify (#2338)
With the optional asserts, we throw if we see an unwind begin in code that we thought could never unwind (say, because the user incorrectly blacklisted it).

Helps with emscripten-core/emscripten#9389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.