Set JAVA_HOME when running closure compiler #10305
Conversation
|
Can we only apply this forced java if user did not pass a |
|
Are you sure you are not using the native version rather than the JS version? It seems the native version is always the default internally. I tried the JS version and it was super slow. But yes I think we should do as you say. I'd also like to find a way to allow the native version to continue to take precedence. |
Oh right, actually when I wrote above comment I forgot the existence of the native version altogether and thought it was the JS version I've been using, yeah, we'd then be using |
sbc100
changed the title
|
Ok, I found a better solution which is simply to set JAVA_HOME. This allows the java backend to be selected in the absence of the native backend. |
|
PTAL ASAP, I'm hoping this change will unblock out release builder and enable us to cut a release. |
This allows the closure compiler to successfully fall back to the java version if the native version is not found. See: google/closure-compiler-npm#160 Fixes #10304
tools/shared.py
Outdated
| env = os.environ.copy() | ||
| env['PATH'] = env['PATH'] + os.pathsep + get_node_directory() | ||
| # Closure compiler expects JAVA_HOME to be set in order to enable the java backend. Without | ||
| # this is will only try the native and javascriptn version. |
There was a problem hiding this comment.
typo in javascript, extra n at the end
This allows the closure compiler to successfully fall back to the
java version if the native version is not found.
See: google/closure-compiler-npm#160
Fixes #10304