Add java bin directory to PATH for closure-compiler #10334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The closure compiler driver requires "java" to be in the PATH in order to use the java backend. https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157 This is yet another attempt for fix #10304. Also address issue from #10328 where --closure-args was not being honored
sbc100
force-pushed
the
add_java_to_path
branch
from
dbacf5b to
3bbe85b
Compare
kripken
approved these changes
Jan 31, 2020
| env['PATH'] = env['PATH'] + os.pathsep + get_node_directory() | ||
| user_args = os.environ.get('EMCC_CLOSURE_ARGS', '') | ||
| def add_to_path(dirname): | ||
| env['PATH'] = env['PATH'] + os.pathsep + dirname |
There was a problem hiding this comment.
I think this function would be clearer after env = , then the reader knows what env is already.
There was a problem hiding this comment.
good point I completely missed that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The closure compiler driver requires "java" to be in the PATH in order
to use the java backend.
https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157
This is yet another attempt for fix #10304.
Also address issue from #10328 where --closure-args was not being
honored