Force java version of closure compile on windows #10328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least until the upstream issue with the native version is fixed. See google/closure-compiler-npm#147
kripken
approved these changes
Jan 31, 2020
tools/shared.py
Outdated
| if java_home: | ||
| env.setdefault('JAVA_HOME', java_home) | ||
| if WINDOWS and '--platform' not in os.environ.get('EMCC_CLOSURE_ARGS'): | ||
| # Disable native compiler on windows until upstream issue if fixes |
juj
reviewed
Jan 31, 2020
| java_home = os.path.dirname(JAVA) | ||
| if java_home: | ||
| env.setdefault('JAVA_HOME', java_home) | ||
| if WINDOWS and '--platform' not in user_args: |
There was a problem hiding this comment.
Why this user_args scheme? If I build from command line with em++ a.c -o a.html -O3 --closure 1 --closure-args "--platform native", it won't work?
There was a problem hiding this comment.
Oh yes I forgot about that. We should support that. I'm just hoping that passing all those other args along with --version will be ok.
In the mean time it looks like "--version --platform=java" still tries to run the native version for some reason :( So out windows build is still broken. Seems like the google-closure npm pacakge has a lot of issues outstanding.
sbc100
added a commit
that referenced
this pull request
Jan 31, 2020
The closure compiler driver requires "java" to be in the PATH in order to use the java backend. https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157 Also address issue from #10328 where --closure-args was not being honored
sbc100
added a commit
that referenced
this pull request
Jan 31, 2020
The closure compiler driver requires "java" to be in the PATH in order to use the java backend. https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157 This is yet another attempt for fix #10304. Also address issue from #10328 where --closure-args was not being honored
sbc100
added a commit
that referenced
this pull request
Jan 31, 2020
The closure compiler driver requires "java" to be in the PATH in order to use the java backend. https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157 This is yet another attempt for fix #10304. Also address issue from #10328 where --closure-args was not being honored
sbc100
added a commit
that referenced
this pull request
Feb 2, 2020
The closure compiler driver requires "java" to be in the PATH in order to use the java backend. https://github.com/google/closure-compiler-npm/blob/308b9e49e8f96211060a0dc466bafe99cddd9f96/packages/google-closure-compiler/lib/node/closure-compiler.js#L157 This is yet another attempt for fix #10304. Also address issue from #10328 where --closure-args was not being honored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least until the upstream issue with the native version is
fixed. See google/closure-compiler-npm#147
Users who really want to try out the native version have the right DLLs installed
can still use the native vesrsion by setting
--platform=nativein$EMCC_CLOSURE_ARGS