Check for expected error codes when running generated JS code#11578
Merged
Check for expected error codes when running generated JS code#11578
Conversation
sbc100
force-pushed
the
assert_on_expected_failures
branch
from
dbf2096 to
a04eb12
Compare
kripken
reviewed
Jul 8, 2020
sbc100
force-pushed
the
assert_on_expected_failures
branch
from
aa0d41b to
0edecc4
Compare
sbc100
changed the title
sbc100
force-pushed
the
assert_on_expected_failures
branch
3 times, most recently
from
986312b to
6d6bc42
Compare
Collaborator
Author
|
This should be good to go now.. |
kripken
reviewed
Jul 8, 2020
Previously we just disabled the check for returning 0. Now we actually check that the program fails. assert_returncode=None now means assert that the subprocess fails with a non-zero error code. This is like specifying a positive integer value but checkes for any positive value.
sbc100
force-pushed
the
assert_on_expected_failures
branch
from
a8a4a77 to
9019cb0
Compare
kripken
approved these changes
Jul 8, 2020
tests/test_benchmark.py
Outdated
|
|
||
| def run(self, args): | ||
| return jsrun.run_js(self.filename, engine=self.engine, args=args, stderr=PIPE, full_output=True, assert_returncode=None) | ||
| return jsrun.run_js(self.filename, engine=self.engine, args=args, stderr=PIPE, full_output=True, assert_returncode=jsrun.NON_ZERO) |
Member
There was a problem hiding this comment.
we don't test the benchmarks on CI, are you sure this is right? I'm surprised this expects a failure.
Collaborator
Author
There was a problem hiding this comment.
I'm changed to expect success. All the other benchmark runners seems to expect success so I don't see why chreep wouldn't. I'm basically removing the ability to be ambivalent about this, so hopefully its easy enough to make sure the cheerp returns zero from these tests.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Apr 14, 2026
- Remove unnecessary command line flags - Check for test output - Return 0 from test (otherwise we don't actually detect asan failures). - Restore final checks to before emscripten-core#11578
sbc100
added a commit
that referenced
this pull request
Apr 14, 2026
- Remove unnecessary command line flags - Check for test output - Return 0 from test (otherwise we don't actually detect asan failures). - Restore final checks to before #11578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we just disabled the check for returning 0. Now we
actually check that the program fails.