Conversation
Collaborator
|
I guess we need to add some tests that load more than one side module? |
sbc100
approved these changes
Dec 16, 2020
Member
Author
|
Looks like |
kripken
added a commit
that referenced
this pull request
Dec 17, 2020
) To test async loading, we have to test this on the web (in node, we'll use sync loading for all files, even dynamic libraries, and not just dlopen). This sort of tests #13060, but that's a race, so it may not have caught it. Still, it gives us coverage we were missing before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If 2 side modules are loaded, A and B, and
loadModuleis called on A, then B,then it is possible that if instantiation is done async here then the
postInstantiation()callbacks may happen in the reverse order, racily. If thathappens, the extra assertions on the table not changing can fire incorrectly -
the other parts of the table will appear to have changed meanwhile, but for
valid reasons.
Fixes #13054
Fixes #11458