Fix handling of indented #include statements in parseTools.js#17135
Open
hoodmane wants to merge 4 commits intoemscripten-core:mainfrom
Open
Fix handling of indented #include statements in parseTools.js#17135hoodmane wants to merge 4 commits intoemscripten-core:mainfrom
hoodmane wants to merge 4 commits intoemscripten-core:mainfrom
Conversation
sbc100
approved these changes
Jun 2, 2022
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
Is it worth added test for this .. maybe in test_js_preprocess?
sbc100
approved these changes
Jun 2, 2022
auto-merge was automatically disabled
June 6, 2022 21:25
Head branch was pushed to by a user without write access
Collaborator
Author
|
I think test failures are not related to my change? |
Collaborator
|
I think it you rebase (or merge) on top of main it should fix those issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.