Skip to content

Comments

Add prettier as an npm dev dependency#18044

Merged
sbc100 merged 1 commit intomainfrom
add_prettier
Oct 12, 2022
Merged

Add prettier as an npm dev dependency#18044
sbc100 merged 1 commit intomainfrom
add_prettier

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 12, 2022

For this initial commit I only chose to apply the formatting to a single JS file.

@sbc100 sbc100 requested review from dschuff and kripken October 12, 2022 16:12
@sbc100 sbc100 force-pushed the add_prettier branch 2 times, most recently from f06b6b6 to 4c9439d Compare October 12, 2022 16:17
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. But I assume we can only use this for files without preprocessing?

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 12, 2022

Good idea. But I assume we can only use this for files without preprocessing?

Yes, it won't work with pre-processed files sadly.

For this initial commit I only chose to apply the formatting to a
single JS file.
@sbc100 sbc100 enabled auto-merge (squash) October 12, 2022 18:59
@sbc100 sbc100 merged commit e4f46f8 into main Oct 12, 2022
@sbc100 sbc100 deleted the add_prettier branch October 12, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants