Open
Conversation
sbc100
force-pushed
the
python_typing_part3
branch
from
9746bed to
9157d85
Compare
This change enabled `disallow_untyped_defs` which forces all functions to be typed, but initially only for `tools/shared.py`. This process uncovered a typo in the exception path of `get_clang_targets`.
sbc100
force-pushed
the
python_typing_part3
branch
from
9157d85 to
58b509f
Compare
sbc100
changed the title
Member
|
This looks like it's more than just typing changes. Can those be either split out, or at least mentioned in the commit message? |
sbc100
added a commit
that referenced
this pull request
Jan 10, 2023
sbc100
added a commit
that referenced
this pull request
Jan 10, 2023
sbc100
added a commit
that referenced
this pull request
Jan 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enabled
disallow_untyped_defswhich forces all functions to be typed, but initially only fortools/shared.py