Skip to content

Remove unnecessary dependency from deps_info.py. NFC #19166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Apr 13, 2023
Merged

Remove unnecessary dependency from deps_info.py. NFC #19166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/other/metadce/test_metadce_cxx_ctors1.exports
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
__cxa_increment_exception_refcount
__cxa_is_pointer_type
__errno_location
__indirect_function_table
Expand Down
2 changes: 1 addition & 1 deletion test/other/metadce/test_metadce_cxx_ctors1.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
123573
123454
1 change: 0 additions & 1 deletion test/other/metadce/test_metadce_cxx_ctors2.exports
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
__cxa_increment_exception_refcount
__cxa_is_pointer_type
__errno_location
__indirect_function_table
Expand Down
2 changes: 1 addition & 1 deletion test/other/metadce/test_metadce_cxx_ctors2.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
123478
123359
1 change: 0 additions & 1 deletion test/other/metadce/test_metadce_cxx_noexcept.exports
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
__cxa_increment_exception_refcount
__cxa_is_pointer_type
__errno_location
__indirect_function_table
Expand Down
2 changes: 1 addition & 1 deletion test/other/metadce/test_metadce_cxx_noexcept.size
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
126371
126251
7 changes: 2 additions & 5 deletions tools/deps_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,12 +186,9 @@ def append_deps_info(js_symbol_deps):
def get_deps_info():
if not settings.WASM_EXCEPTIONS and settings.LINK_AS_CXX:
_deps_info['__cxa_end_catch'] = ['setThrew', '__cxa_decrement_exception_refcount']
base_js_exception_deps = [
'__cxa_is_pointer_type',
'__cxa_increment_exception_refcount',
]
base_js_exception_deps = ['__cxa_is_pointer_type']
_deps_info['__cxa_throw'] = base_js_exception_deps
_deps_info['__cxa_begin_catch'] = base_js_exception_deps
_deps_info['__cxa_begin_catch'] = base_js_exception_deps + ['__cxa_increment_exception_refcount']
_deps_info['__cxa_find_matching_catch'] = base_js_exception_deps + ['__cxa_can_catch', 'setTempRet0']
for i in range(1, 10):
_deps_info['__cxa_find_matching_catch_%d' % i] = _deps_info['__cxa_find_matching_catch']
Expand Down