Add auto-generated signatures for LEGACY_GL_EMULATION symbols. NFC #19235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
commented
Apr 24, 2023
| if '_main' in settings.EXPORTED_FUNCTIONS: | ||
| settings.EXPORT_IF_DEFINED.append('__main_argc_argv') | ||
| elif settings.ASSERTIONS: | ||
| elif settings.ASSERTIONS and not settings.STANDALONE_WASM: |
There was a problem hiding this comment.
This is drive by fix. I notices that we were generating the "main exists but not exported" warning in standalone mode, where it does not apply (since we export _start instead and its not optional in the same way)
There was a problem hiding this comment.
sgtm but please add a comment on the source explaining that.
kripken
approved these changes
Apr 24, 2023
| if '_main' in settings.EXPORTED_FUNCTIONS: | ||
| settings.EXPORT_IF_DEFINED.append('__main_argc_argv') | ||
| elif settings.ASSERTIONS: | ||
| elif settings.ASSERTIONS and not settings.STANDALONE_WASM: |
There was a problem hiding this comment.
sgtm but please add a comment on the source explaining that.
I had to add declaration for a few GL extensions which we define in JS both via the ARB name as well as the base name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to add declaration for a few GL extensions which we define in JS both via the ARB name as well as the base name.